Skip to content

Readme script update #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Readme script update #1750

wants to merge 2 commits into from

Conversation

cristianmihaipopa
Copy link
Collaborator

PR Description

Updated the check_for_missing_readme_md.sh which is responsible to check README files based on the newly implemented documentation guidelines. Also, updated the .md file renaming it to README.md format. In this file are described the two scripts and there're also highlighted the documentation rules regarding README files.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)
  • Documentation

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

- Updated the script for to check the README files of
the projects based on the new documentation guidlines
- Checks for sections, title format, prohibited links, file
format & structure within the project's folder.

Signed-off-by: Cristian Mihai Popa <[email protected]>
- Renamed to README.md
- Contains info about the check_for_missing_readme_md.sh and
check_guideline.py
- Highlights the guidlines which must be followed when
writting a new README file

Signed-off-by: Cristian Mihai Popa <[email protected]>
@@ -1,55 +1,162 @@
# User guide for [check_guideline.py](https://github.com/analogdevicesinc/hdl/tree/main/.github/scripts/check_guideline.py)
# Guidlines & files check scripts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Guidlines & files check scripts
# Guidelines & files check scripts

Comment on lines +3 to +4
This scripts are used for checking the integrity and correctness of the
files across HDL/ repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This scripts are used for checking the integrity and correctness of the
files across HDL/ repository.
This script is used for checking the integrity and correctness of the README
files across the HDL repository.

files across HDL/ repository.

## User guide for [check_for_missing_readme_md.sh](https://github.com/analogdevicesinc/hdl/blob/main/.github/scripts/check_for_missing_readme_md.sh)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change


#### 3. Special carrier exceptions

The following carriers are allowed to use hyphens in their README titles and are not flagged for title mismatches:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The following carriers are allowed to use hyphens in their README titles and are not flagged for title mismatches:
The following carriers are allowed to use underscore in their README titles and are not flagged for title mismatches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants