fix #501 #768
Open
fix #501 #768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsukoe
approved these changes
Aug 6, 2024
kitsukoe
left a comment
kitsukoe
left a comment
There was a problem hiding this comment.
The fix does exactly what it says it does. It fixes the problem of contours not working in RGBA mode, and doesn't look like it will break anything else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue was caused when using RGB mask and requesting RGBA output.
Arrays had differing dimensions (mask did not have alpha).
Duplicate a channel and append it to the contour, this allows the subsequent math operations.
Followed instructions in CONTRIBUTING.md, flake8 and pytest.
flake8 reports 2 lines in wordcloud_cli.py (that I did not touch)
pytest passes all 76 collected items