Skip to content

Allowing multiple classes on klass.selectYear and klass.selectMonth #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allowing multiple classes on klass.selectYear and klass.selectMonth #852

wants to merge 1 commit into from

Conversation

fernandosavio
Copy link

Allowing multiple classes on klass.selectYear and klass.selectMonth options.
$.trim() used to maintain IE8+ compatibility.

@fernandosavio
Allowing klass.selectYear and klass.selectMonth having multiple c…
36f48d1 
…lasses

`$.trim()` used to maintain IE8+ compatibility.
@DanielRuf DanielRuf self-requested a review March 31, 2018 21:10
DanielRuf
DanielRuf suggested changes Mar 31, 2018
View reviewed changes
Copy link
Contributor

@DanielRuf DanielRuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arrays could be better. So we would still use strings but one class = 1 string and multiple classes = array of strings. Also easier to traverse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@DanielRuf DanielRuf DanielRuf requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fernandosavio @DanielRuf