Skip to content

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Dec 21, 2021

See changelog for v8.4.0.

PHP-CSS-Parser went a long time without a release. Version 8.3.0 was released 2019-02-22, and in order to deploy unreleased improvements we updated to include the commits we needed (#4300, #5081) in addition to applying additional patches (#5392, #4290, etc).

Changes between v8.3.0 and what we released: MyIntervals/PHP-CSS-Parser@8.3.0...bfdd976
Changes between what we released and v8.4.0: MyIntervals/PHP-CSS-Parser@bfdd976...8.4.0

So this PR updates to the latest stable release as well as:

  • Remove now-obsolete php-css-parser-install-composer-plugin.
  • Bump stylesheet cache group.
  • Update patches to address merge conflicts.

Additional patches on top of v8.4.0 are applied from these PRs:

@westonruter westonruter added the dependencies Pull requests that update a dependency file label Dec 21, 2021
@westonruter westonruter added this to the v2.3 milestone Dec 21, 2021
@westonruter westonruter force-pushed the update/php-css-parser-8.4.0 branch from e0c392b to 9d29e1d Compare December 21, 2021 04:39
@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2021

Plugin builds for ee6f7c7 are ready 🛎️!

@westonruter westonruter modified the milestones: v2.3, v2.2.2 Feb 3, 2022
Copy link
Collaborator

@dhaval-parekh dhaval-parekh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me.

@westonruter
Copy link
Member Author

Eesh. I just found that the patches fail to apply when running composer install --prefer-dist but they succeed when running composer install --prefer-source.

@westonruter
Copy link
Member Author

Yeah, it's also failing in the GHA build:

  - Applying patches for sabberworm/php-css-parser
    https://github.com/sabberworm/PHP-CSS-Parser/compare/e41d2140031d533348b2192a83f02d8dd8a71d30...b1f74798a7d21d0e6f6402ee8a06c92c7f92fae5.diff (1. Add additional validation for size unit <https://github.com/sabberworm/PHP-CSS-Parser/pull/350>)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://github.com/sabberworm/PHP-CSS-Parser/compare/e41d2140031d533348b2192a83f02d8dd8a71d30...b1f74798a7d21d0e6f6402ee8a06c92c7f92fae5.diff
    https://github.com/westonruter/PHP-CSS-Parser/compare/e41d2140031d533348b2192a83f02d8dd8a71d30...a49bd92c35e9bbbaaca23cf33874a65dd485c30b.diff (2. Validate name-start code points for identifier <https://github.com/westonruter/PHP-CSS-Parser/pull/2>)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://github.com/westonruter/PHP-CSS-Parser/compare/e41d2140031d533348b2192a83f02d8dd8a71d30...a49bd92c35e9bbbaaca23cf33874a65dd485c30b.diff
    https://github.com/westonruter/PHP-CSS-Parser/compare/e41d2140031d533348b2192a83f02d8dd8a71d30...935ea79e0389e672a9deadf9f366e6faab9110ba.diff (3. Fix parsing CSS selectors which contain commas <https://github.com/westonruter/PHP-CSS-Parser/pull/1>)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://github.com/westonruter/PHP-CSS-Parser/compare/e41d2140031d533348b2192a83f02d8dd8a71d30...935ea79e0389e672a9deadf9f366e6faab9110ba.diff

I believe it's due to the patches including changes to tests which aren't included in dist.

@westonruter westonruter force-pushed the update/php-css-parser-8.4.0 branch from 4bee0af to 0d16778 Compare February 24, 2022 05:31
@westonruter westonruter force-pushed the update/php-css-parser-8.4.0 branch from 0d16778 to ee6f7c7 Compare February 24, 2022 06:04
@maitreyie-chavan
Copy link
Collaborator

@dhaval-parekh Please could you review this again further to the findings @westonruter shared and new changes pushed.

@westonruter westonruter merged commit e9fce01 into develop Mar 3, 2022
@westonruter westonruter deleted the update/php-css-parser-8.4.0 branch March 3, 2022 01:38
westonruter added a commit that referenced this pull request Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants