-
Notifications
You must be signed in to change notification settings - Fork 381
Upgrade php-css-parser to v8.4.0 #6800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e0c392b
to
9d29e1d
Compare
Plugin builds for ee6f7c7 are ready 🛎️!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me.
Eesh. I just found that the patches fail to apply when running |
Yeah, it's also failing in the GHA build:
I believe it's due to the patches including changes to |
4bee0af
to
0d16778
Compare
0d16778
to
ee6f7c7
Compare
@dhaval-parekh Please could you review this again further to the findings @westonruter shared and new changes pushed. |
See changelog for v8.4.0.
PHP-CSS-Parser went a long time without a release. Version 8.3.0 was released 2019-02-22, and in order to deploy unreleased improvements we updated to include the commits we needed (#4300, #5081) in addition to applying additional patches (#5392, #4290, etc).
Changes between v8.3.0 and what we released: MyIntervals/PHP-CSS-Parser@8.3.0...bfdd976
Changes between what we released and v8.4.0: MyIntervals/PHP-CSS-Parser@bfdd976...8.4.0
So this PR updates to the latest stable release as well as:
Additional patches on top of v8.4.0 are applied from these PRs:
turns
unit withturn
MyIntervals/PHP-CSS-Parser#350