Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

typescript version added, javascript version fixed #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

typescript version added, javascript version fixed #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5ce63c
typescript version added, javascript version fixed for IBAN with doub…
andrea-calabretta Nov 4, 2021
1322649
[javascript/typescript] regex optimized
andrea-calabretta Dec 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
*~
my.cnf
*.reject
node_modules
54 changes: 35 additions & 19 deletions src/javascript/iban.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
*/
function isValidIBAN( accNumber ) {
var isValid = false;
var countryCode = accNumber.substr( 0, 2 );
var writenDigits = accNumber.substr( 2, 2 );
var countryCode = accNumber.substr( 0, 2 ); //IT
var writenDigits = accNumber.substr( 2, 2 ); // 44

if ( isSepaCountry( countryCode ) ) {
if ( accNumber.length == getAccountLength( countryCode ) ) {
Expand Down Expand Up @@ -38,7 +38,6 @@
if ( getAccountLength( countryCode ) != 0 ) {
isSepa = true;
}

return isSepa;
}

Expand Down Expand Up @@ -96,7 +95,6 @@
var part = divident.substring(0, partLength);
divident = (part % divisor) + divident.substring(partLength);
}

return divident % divisor;
}

Expand Down Expand Up @@ -125,7 +123,8 @@
if( accNumber.length == accountLength ) {
/* Replace the two check digits by 00 (e.g., GB00 for the UK) and
Move the four initial characters to the end of the string. */
accRearranged =

accRearranged =
accNumber.substr( 4 - accNumber.length ) + accNumber.substr( 0, 2 ) + '00';

/* Replace the letters in the string with digits, expanding the string as necessary,
Expand All @@ -146,7 +145,6 @@

}
}

return digits;
}

Expand Down Expand Up @@ -237,25 +235,43 @@

/*
* replaceLetterWithDigits changes letters in a given string with its
* correspondent numbers, as described in ECBS EBS204 V3.2 [August 2003]
* document: A=1, B=2, ..., Y=34, Z=35.
* correspondent numbers: A=10, B=11, ..., Y=34, Z=35.
*
* @link https://github.com/amnesty/dataquality/wiki/replaceLetterWithDigits
*/
function replaceLetterWithDigits( accNumber ) {
var letters = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
var findLetter = "";
var replaceWith = 0;
var i = 0;

while( i <= letters.length ) {
findLetter = letters.substr( i-1, 1 );
replaceWith = letters.indexOf( findLetter ) + 10;
accNumber = accNumber.replace( findLetter, replaceWith );

i++;
regExAllLetters = /[A-Z]/g;

var AllLetters = accNumber.matchAll(regExAllLetters);
var AllLettersNoDuplicates = [...new Set(AllLetters)]

const letterToDigits = {
'A': '10',
'B': '11', 'C': '12', 'D': '13', 'E': '14', 'F': '15',
'G': '16', 'H': '17', 'I': '18', 'J': '19', 'K': '20',
'L': '21', 'M': '22', 'N': '23', 'O': '24', 'P': '25',
'Q': '26', 'R': '27', 'S': '28', 'T': '29', 'U': '30',
'V': '30', 'W': '31', 'X': '32', 'Y': '33', 'Z': '35'
}


var positionLetter = []

AllLettersNoDuplicates.forEach(match => positionLetter.push({"position": match.index, "letter": match[0] }))

return accNumber;
arrayAccNumber = [...accNumber];
positionLetter.forEach(item => arrayAccNumber.splice(item.position, 1, letterToDigits[item.letter]) )
accNumber = arrayAccNumber.join("");

return accNumber;
}

var validIbanDE = 'DE29100100100987654321'
var notValidIbanDE = 'DE28100100100987654321'

console.log("ibanDE: ", validIbanDE);
console.log("ibanDE: ", isValidIBAN(validIbanDE));
console.log("ibanDE: ", notValidIbanDE);
console.log("ibanDE: ", isValidIBAN(notValidIbanDE));

238 changes: 238 additions & 0 deletions src/typescript/iban.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,238 @@
var __spreadArrays = (this && this.__spreadArrays) || function () {
for (var s = 0, i = 0, il = arguments.length; i < il; i++) s += arguments[i].length;
for (var r = Array(s), k = 0, i = 0; i < il; i++)
for (var a = arguments[i], j = 0, jl = a.length; j < jl; j++, k++)
r[k] = a[j];
return r;
};
/*
* isValidIBAN validates an IBAN by verifying its structure and
* check digits.
*
* @link https://github.com/amnesty/dataquality/wiki/isValidIBAN
*/
function isValidIBAN(accNumber) {
var isValid = false;
var countryCode = accNumber.substr(0, 2);
var writenDigits = accNumber.substr(2, 2);
if (isSepaCountry(countryCode)) {
if (accNumber.length == getAccountLength(countryCode)) {
if (writenDigits == getIBANCheckDigits(accNumber)) {
isValid = true;
}
}
}
return isValid;
}
/*
* isSepaCountry helps to check the first two digits of an IBAN.
* These two digits are referring to the country where the
* account was created, so they only can correspond to one
* of the countries in the Single Euro Payments Area (SEPA) area.
*
* A document with a full list of the SEPA countries, its
* corresponding IBAN structures and more is available at
* the Swift website as IBAN Registry.
*
* @link https://github.com/amnesty/dataquality/wiki/isSepaCountry
*/
function isSepaCountry(countryCode) {
var isSepa = false;
if (getAccountLength(countryCode) != 0) {
isSepa = true;
}
return isSepa;
}
/*
* getAccountLength returns the expected length for an IBAN given
* its first two digits. For instance, British accounts have 22
* characters when written in IBAN electronic format.
*
* @link https://github.com/amnesty/dataquality/wiki/getAccountLength
*/
function getAccountLength(countryCode) {
var accountLength = 0;
/* Information Source: IBAN Registry about all ISO 13616-compliant
national IBAN formats (Release 45 – April 2013).
http://www.swift.com/dsp/resources/documents/IBAN_Registry.pdf */
var accountLengthPerCountry = {
'AL': 28, 'AD': 24, 'AT': 20, 'AZ': 28, 'BH': 22,
'BE': 16, 'BA': 20, 'BR': 29, 'BG': 22, 'CR': 21,
'HR': 21, 'CY': 28, 'CZ': 24, 'DK': 18, 'DO': 28,
'EE': 20, 'FO': 18, 'FI': 18, 'FR': 27, 'GE': 22,
'DE': 22, 'GI': 23, 'GR': 27, 'GL': 18, 'GT': 28,
'HU': 28, 'IS': 26, 'IE': 22, 'IL': 23, 'IT': 27,
'KZ': 20, 'KW': 30, 'LV': 21, 'LB': 28, 'LI': 21,
'LT': 20, 'LU': 20, 'MK': 19, 'MT': 31, 'MR': 27,
'MU': 30, 'MC': 27, 'MD': 24, 'ME': 22, 'NL': 18,
'NO': 15, 'PK': 24, 'PS': 29, 'PL': 28, 'PT': 25,
'RO': 24, 'SM': 27, 'SA': 24, 'RS': 22, 'SK': 24,
'SI': 19, 'ES': 24, 'SE': 24, 'CH': 21, 'TN': 24,
'TR': 26, 'AE': 23, 'GB': 22, 'VG': 24, 'AO': 25,
'BJ': 28, 'BF': 27, 'BI': 16, 'CM': 27, 'CV': 25,
'IR': 26, 'CI': 28, 'MG': 27, 'ML': 28, 'MZ': 25,
'SN': 28
};
if (countryCode) {
if (countryCode in accountLengthPerCountry) {
accountLength = accountLengthPerCountry[countryCode];
}
}
return accountLength;
}
/*
* Auxiliary function. Helps to calculate modulus when working
* with big integers.
*
* @link http://stackoverflow.com/questions/929910/modulo-in-javascript-large-number
*/
function modulus(divident, divisor) {
var partLength = 10;
while (divident.length > partLength) {
var part = divident.substring(0, partLength);
divident = (Number(part) % divisor) + divident.substring(partLength);
}
return Number(divident) % divisor;
}
/*
* This function expects the entire account number in the electronic
* format (without spaces), as described in the ISO 13616-Compliant
* IBAN Formats document.
*
* You can replace check digits with zeros when calling the function.
*
* @link https://github.com/amnesty/dataquality/wiki/getIBANCheckDigits
*/
function getIBANCheckDigits(accNumber) {
var countryCode = "";
var accountLength = 0;
var accRearranged = "";
var accWithoutLetters = "";
var accMod97 = 0;
var digits = "";
var digitsWithZeros = "";
countryCode = accNumber.substr(0, 2);
accountLength = getAccountLength(countryCode);
if (isSepaCountry(countryCode)) {
if (accNumber.length == accountLength) {
/* Replace the two check digits by 00 (e.g., GB00 for the UK) and
Move the four initial characters to the end of the string. */
accRearranged =
accNumber.substr(4 - accNumber.length) + accNumber.substr(0, 2) + '00';
/* Replace the letters in the string with digits, expanding the string as necessary,
such that A or a = 10, B or b = 11, and Z or z = 35.
Each alphabetic character is therefore replaced by 2 digits. */
accWithoutLetters = replaceLetterWithDigits(accRearranged);
/* Convert the string to an integer (i.e., ignore leading zeroes) and
Calculate mod-97 of the new number, which results in the remainder. */
accMod97 = modulus(accWithoutLetters, 97);
/* Subtract the remainder from 98, and use the result for the two check digits. */
digits = String(98 - accMod97);
/* If the result is a single digit number, pad it with a leading 0 to make a two-digit number. */
digitsWithZeros = '00' + digits.toString();
digits = digitsWithZeros.substr(-2);
}
}
return digits;
}
/*
* This "global identifier" refers to the code AT-02 created for the
* C19.14. The C19.14 is a temporary file format to be used in Spain
* until the ISO 20022 XML format is finally adopted.
*
* If the IBAN is built by adding a few digits to the national bank
* accounts, the AT-02 is build by adding digits to the national
* identifier. In the case of Spain, this identifiers are NIFs,
* NIEs and CIFs.
*
* For instance, the Spanish CIF G28667152, can be expressed
* internationally as ES03000G28667152.
*
* @link https://github.com/amnesty/dataquality/wiki/getGlobalIdentifier
*/
function getGlobalIdentifier(localId, countryCode, suffix) {
var alphaNumerical = "";
var withCountry = "";
var withoutLetters = "";
var mod97 = 0;
var digitsWithZeros = "";
var digits = "";
var suffixWithZeros = "";
var globalId = "";
/* Removes non alpha-numerical characters */
alphaNumerical = replaceCharactersNotInPattern(localId, 'ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789', '');
/* Concatenate localId plus country code and two zeros (00) */
withCountry = alphaNumerical + countryCode + '00';
/* Replace the letters in the string with digits, expanding the string as necessary,
such that A or a = 10, B or b = 11, and Z or z = 35.
Each alphabetic character is therefore replaced by 2 digits. */
withoutLetters = replaceLetterWithDigits(withCountry);
/* Convert the string to an integer (i.e., ignore leading zeroes) and
Calculate mod-97 of the new number, which results in the remainder. */
mod97 = Number(withoutLetters) % 97;
/* Subtract the remainder from 98, and use the result for the two check digits. */
digits = String(98 - mod97);
/* If the result is a single digit number, pad it with a leading 0 to make a two-digit number. */
digitsWithZeros = '00' + digits;
digits = digitsWithZeros.substr(-2);
/* Suffix must be a number from 000 to 999 */
suffix = replaceCharactersNotInPattern(suffix, '0123456789', '0');
suffixWithZeros = '000' + suffix;
suffix = suffixWithZeros.substr(-3);
return countryCode + digits + suffix + localId;
}
/*
* replaceCharactersNotInPattern replaces unwanted characters from a string
* with a given character.
*
* An example:
* - We have this string: 1!2/3·A|B@C#
* - This are the characters we accept: 123ABC
* - This is the character we want to replace extra characters with: 0
* - The example would return: 102030A0B0C0
*
* @link https://github.com/amnesty/dataquality/wiki/replaceCharactersNotInPattern
*/
function replaceCharactersNotInPattern(givenString, pattern, replaceWith) {
var verifyLetter = "";
var i = 1;
while (i <= givenString.length) {
verifyLetter = givenString.substr(i - 1, 1);
if (pattern.indexOf(verifyLetter) < 0) {
givenString = givenString.replace(verifyLetter, replaceWith);
}
i++;
}
return givenString;
}
/*
* replaceLetterWithDigits changes letters in a given string with its
* correspondent numbers: A=10, B=11, ..., Y=34, Z=35.
*
* @link https://github.com/amnesty/dataquality/wiki/replaceLetterWithDigits
*/
function replaceLetterWithDigits(accNumber) {
var regExAllLetters = /[A-Z]/g;
var AllLetters = accNumber.matchAll(regExAllLetters);
var AllLettersNoDuplicates = __spreadArrays(Array.from(new Set(AllLetters)));
var letterToDigits = {
'A': '10',
'B': '11', 'C': '12', 'D': '13', 'E': '14', 'F': '15',
'G': '16', 'H': '17', 'I': '18', 'J': '19', 'K': '20',
'L': '21', 'M': '22', 'N': '23', 'O': '24', 'P': '25',
'Q': '26', 'R': '27', 'S': '28', 'T': '29', 'U': '30',
'V': '30', 'W': '31', 'X': '32', 'Y': '33', 'Z': '35'
};
var positionLetter = [];
AllLettersNoDuplicates.forEach(function (match) { return positionLetter.push({ "position": match.index, "letter": match[0] }); });
var arrayAccNumber = __spreadArrays(Array.from(accNumber));
positionLetter.forEach(function (item) { return arrayAccNumber.splice(item.position, 1, letterToDigits[item.letter]); });
accNumber = arrayAccNumber.join("");
return accNumber;
}
var validIbanDE = 'DE29100100100987654321';
var notValidIbanDE = 'DE28100100100987654321';
console.log("ibanDE: ", validIbanDE);
console.log("ibanDE: ", isValidIBAN(validIbanDE));
console.log("ibanDE: ", notValidIbanDE);
console.log("ibanDE: ", isValidIBAN(notValidIbanDE));
Loading