Don't try to use removed -watchdog arg
#85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The next commit will add a check against 7.2 which makes for an unwieldy regex. Let's use numerical comparisons instead
|
There is also #81. |
|
Oh Well, I'll leave this open in case the simple |
|
@amluto has been unreachable for quite some time... do any of you know if he is still around? There a couple of fixes waiting to be picked in the PR lists already. |
|
I just learned about https://github.com/arighi/virtme-ng, haven't tried it but maybe a viable alternative. |
It works quite well, actually. You should try it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://www.qemu.org/docs/master/about/removed-features.html
Implementation notes:
I wrote out this numeric parsing logic for the version check to avoid a big regex. Not sure if it's worth it, LMK if you prefer and I'll just switch it back to the existing system.
Adding
has_watchdog_argeverywhere looks a bit annoying, maybe better to just pass theQemuin or something and then let architectures check whatever flags they like?Possibly we could just skip all this and use
-deviceunconditionally, I have no idea when in QEMU's version history that became valid. In that case we can just merge s/-watchdog/-device #81 and delete this.