Update gtkdialog to 0.8.5e

[privatezero]

This seems needed to keep things happy on Linux (Ubuntu) - does this update work on the Mac side of things?

[privatezero]

Hmm, so far in testing on my mac it seems that this version might not build on macOS (at least with our current install formula). Does it go against any Homebrew practices to have a system check for which version to install?

[retokromer]

Does it go against any Homebrew practices to have a system check for which version to install?

You can indeed chose different versions according to different OS.

[privatezero]

@retokromer - just added a conditional in f3e7515. Not sure how this lines up with preferred formula style though - is there an 'official' way to do this?

[retokromer]

Is also revision 7 needed?

[privatezero]

good point!

[retokromer]

@privatezero On which macOS version did you encounter an error?

[privatezero]

I forget what I was testing on before - a relatively old version of macOS (probably one of the 10.13s) - I've just gone to macOS 15.7.2 in our lab and am still encountering build errors for gtkdialog 0.8.5 so the conditional seems to still be needed.

[retokromer]

Hello @privatezero : I just run additional tests. On my end, this formula (i.e. patch for macOS removed) works fine on macOS 26.1 and 15.7.2, in addition to Debian 13.1:

class Gtkdialog < Formula
  desc "Small utility for fast and easy GUI building"
  homepage "https://code.google.com/archive/p/gtkdialog/"
  url "https://github.com/puppylinux-woof-CE/gtkdialog/archive/refs/tags/0.8.5e.tar.gz"
  sha256 "93561ed4042c113b85aa5550f51ae4e6980a5de6e083db5c358d6fc2fb2feb0a"

  depends_on "at-spi2-core" => :build
  depends_on "autoconf" => :build
  depends_on "automake" => :build
  depends_on "cairo" => :build
  depends_on "fontconfig" => :build
  depends_on "freetype" => :build
  depends_on "fribidi" => :build
  depends_on "gdk-pixbuf" => :build
  depends_on "gettext" => :build
  depends_on "glib" => :build
  depends_on "graphite2" => :build
  depends_on "harfbuzz" => :build
  depends_on "libepoxy" => :build
  depends_on "libffi" => :build
  depends_on "libpng" => :build
  depends_on "libpthread-stubs" => :build
  depends_on "libtiff" => :build
  depends_on "libx11" => :build
  depends_on "libxau" => :build
  depends_on "libxcb" => :build
  depends_on "libxdmcp" => :build
  depends_on "libxext" => :build
  depends_on "libxrender" => :build
  depends_on "pango" => :build
  depends_on "pixman" => :build
  depends_on "pkg-config" => :build
  depends_on "texinfo" => :build # for makeinfo
  depends_on "xorgproto" => :build

  depends_on "gtk+"

  def install
    ENV.append_to_cflags "-Wno-implicit-function-declaration" # Workaround for Xcode 14.3.
    system "./autogen.sh"
    system "make"
    bin.install "src/gtkdialog"
  end
end

[retokromer]

I opened another PR for this.