Attendance Page #36
Attendance Page #36
Conversation
✅ Deploy Preview for zingy-speculoos-372a93 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thanks for the PR! I'll leave the actual review of the code to @sabarixr, but I wanted to share some suggestions regarding the structure of the PR itself. Firstly, I noticed that you have a lot of commits in the PR, while this is not inherently a bad thing you might want to consider squashing certain commits to make sure that they are modular, i.e. it only does one thing. Here in particular, you added a radar graph in one commit and removed it in a later commit, so this would be a perfect opportunity to squash the two and just name it something like Coming to the commit messages themselves, they are a bit clunky. The commit messages should concisely summarize the changes made, should use proper grammar and be in the imperative mood. I'm seeing a lot of grammatical mistakes in yours, it's not a bad idea to run them once through GPT to make sure they are proper. Thirdly, whenever it comes to UI changes, it's always a good idea to include a few screenshots displaying your work. |
… breakdown - Initially implemented radar chart - Tried year-based radar breakdown (didn't work) - Replaced with a cleaner pie chart
…ble dynamic year range Removed the default white styling in Safari’s calendar dropdown using appearance-none in Tailwind CSS.
Attendance Tracking System Enhancements
This release brings significant improvements to our attendance tracking system, focusing on more efficient data retrieval, enhanced visual reporting, and greater flexibility for historical data access.
Optimized Attendance Data Retrieval
We've refined the data fetching process within
attendance-service.ts. Previously, two separate database queries were executed: one for basic member details (member ID, name, year) and another for their specific attendance records (member ID, time-in, time-out, and present status). After retrieving these, a mapping function combined the data for each member.Now, we've consolidated these into a single, comprehensive query. This new query efficiently retrieves all necessary member and attendance information at once. As a result, the subsequent mapping logic in the
AttendanceServicefunction is no longer needed and has been removed, leading to cleaner code and improved performance.New Attendance Metrics Visualizations
To provide a clearer and more immediate overview of attendance, we've added new visual components to the right side of the page:
These charts display the number of members present, absent, and late, offering quick, at-a-glance insights into daily attendance patterns.
Enhanced Calendar Component Functionality
The calendar component has been upgraded to make accessing historical attendance data much easier: