This repository was archived by the owner on Jan 10, 2019. It is now read-only.
Make sure and let long polling finish before shutting down #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Anyone at AWS have any thoughts on this? If its the right thing to do, then I would like to merge this so I can delete my fork. |
Author
|
Any thoughts on this. It's been almost a year. If there are changes that need to be made, I'd be happy to do them. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31.
This makes sure that we don't kill the worker process during a long poll. This will allow the long poll to complete, finish any task returned by the long poll and then kill the process. We could in theory terminate faster if we could cancel the long poll, but it appears that the AWS SDK doesn't allow that.
See my comments #31 for a better explanation of the bug and it's root cause.