Update tab instead of create; close with timeout #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change from
chrome.tabs.updatetochrome.tabs.createin 8519cde made it so using the context menu would leave an empty tab behind.(Brave also started popping up "A website wants to open this application" confirmation messages every time, which was extremely annoying; I don't know if that was a result of the change, or of an unrelated browser update. I worked around it with registry changes, but the open tab still bothered me.)
When clicking the extension icon, I couldn't find a good way to wait for the custom protocol handler to run and then close the current tab, so I resorted to a
setTimeout.