FakeAIOKafkaConsumer async iterator #235
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches aiokafka's behaviour aside from how we handle running out of messages, where we exit the loop rather than blocking. This is imperfect, but may be as good as we can get. Fixes alm0ra#224
AMelacini
approved these changes
Oct 4, 2025
AMelacini
left a comment
AMelacini
left a comment
There was a problem hiding this comment.
After looking at the code and exercising the tests (taking also a look at their coverage)
I believe the PR is suitable for to be merged into main.
|
Any plans to merge this PR to main? @alm0ra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches
aiokafka's behaviour aside from how we handle running out of messages, where we exit the loop rather than blocking. This is imperfect, but may be as good as we can get.Fixes #224.