-
-
Notifications
You must be signed in to change notification settings - Fork 31
feat: Nix Shell #799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Nix Shell #799
Conversation
Reviewer's Guide by SourceryThis pull request introduces a Nix flake configuration for the project, enabling reproducible development environments. It includes No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @maningreen - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a
.envrc
file with direnv to automatically load the environment when entering the project directory. - It might be helpful to add some common development tools to the nix shell, such as
git
orjq
.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
It's ready to merge now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Waiting till we merge the pre-0.1 branch into main before accepting as there will likely be merge conflicts / adjustments needing to be made. |
pre-0.1 has been merged into main @kzndotsh |
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@maningreen @midirhee12 whats the progress on this? should it be converted to draft or is it ready to review |
@electron271 It should be ready to merge. But I'm going to make a few follow up PRs for database and such. I think it would better to make a separate nix shell for it. |
alright, ill look into getting someone to review. before i would like to ask is it possible for envrc to just be auto generated from .env.example so we do not have to update it each time .env.example is updated also keep in mind db stuff will be rewritten in a different ORM |
direnv/direnv#284 this has some info, if this is possible please figure out before merging |
@electron271 Yeah, I can make a shell hook recreate it from the current example. Let me update the PR before merging. Feel free to bug me again if I don't get to it. |
Ha, I just noticed. Know quite a few of the guys in this issue. I can ask for help if need be. But I think we'll be alright. |
|
@midirhee12 did you forget |
@electron271 Did not. But thanks for the ping anyways. |
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@maningreen I did the thing. Merge the PR. |
@electron271 We're ready now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Are there plans on using Nix to build/package Tux in the future as well?
@juuyokka Yea, I got a whole list of things I want to go after. But I want to piece meal since it's gonna be multiple derivations, multiple shells, a few things to generate docker images, etc. |
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. If this change fixes any issues please put "Fixes #XX" in the description. Please also ensure to add the appropriate labels to the PR.
Guidelines
My code follows the style guidelines of this project (formatted with Ruff)
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation if needed
My changes generate no new warnings
I have tested this change
Any dependent changes have been merged and published in downstream modules
I have added all appropriate labels to this PR
I have followed all of these guidelines.
How Has This Been Tested? (if applicable)
Ran dev shell and check nix flake show, and built tux from poetry.
Summary by Sourcery
Add Nix development shell configuration for the Tux project, enabling reproducible and consistent development environments across different systems.
New Features:
Enhancements:
Build: