Skip to content

fix: audit Trail of Bits - 23-12-2024 #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

fix: audit Trail of Bits - 23-12-2024 #65

wants to merge 9 commits into from

Conversation

0xAustrian
Copy link

@0xAustrian 0xAustrian commented Feb 4, 2025 •
edited
Loading

This PR fixes:

  • TOB-GITCOIN-1: fc36504
  • TOB-GITCOIN-2: b859f7e
  • TOB-GITCOIN-3: ee89f29
  • TOB-GITCOIN-5: 64239ce
  • Non-Security-Related Recommendations (N2): ee89f29
  • Non-Security-Related Recommendations (N3): cb213be
  • Non-Security-Related Recommendations (N4): b2adabd

The next issues were ignored by the team:

  • TOB-GITCOIN-4 with reason: change would be too big for a little reward. The work requires modiying contstructor and all strategies.
  • Non-Security-Related Recommendations (N1) with reason: low impact

@0xAustrian 0xAustrian self-assigned this Feb 4, 2025
@0xAustrian 0xAustrian marked this pull request as ready for review February 4, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xOneTony 0xOneTony 0xOneTony approved these changes

Assignees

@0xAustrian 0xAustrian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xAustrian @0xOneTony