Skip to content

Conversation

@facundoq
Copy link

@facundoq facundoq commented May 27, 2025

…finite when sklearn version >=1.6

Description

This is a fix for #590 and future proofs pmdarima for sklearn >= 1.8

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce. Please also list any relevant details
for your test configuration

I've tested by running pmdarima unit tests with two separate venvs, one with sklearn>= 1.6 and the other sklearn<1.6.

Since this is platform dependent, there's no need to add further tests.
In fact, this change actually causes the following tests to pass with sklearn>=1.6 (they failed before because they depended on the number of warnings being raised):

pmdarima/arima/tests/test_auto.py::test_oob_with_zero_out_of_sample_size pmdarima/arima/tests/test_utils.py::test_issue_351

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant