Dataflow cost metrics #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpeter8
requested changes
Aug 8, 2018
Collaborator
fpeter8
left a comment
fpeter8
left a comment
There was a problem hiding this comment.
The cost does not always appear.
To reproduce:
- Go to https://console.cloud.google.com/dataflow
- Hit ctrl + F5
- After reload, go into a pipeline detail view
- See that the cost lines are not there
| currentMemory * prices.ramTime.amount + | ||
| currentVCPUs * cpuPrice.amount; | ||
|
|
||
| return cost.toFixed(2) + ' ' + prices.ramTime.currencyCode + '/ hr'; |
Collaborator
There was a problem hiding this comment.
To be consistent with the table, I'd remove the / before the hr
fpeter8
reviewed
Aug 10, 2018
|
|
||
| public async getDataflowCostMetricsPrices(region: string): Promise<DataflowCostMetricPrices> { | ||
| const prices = await this.listDataflowPrices(); | ||
| const regionalPrices = prices.filter(sku => sku.serviceRegions.includes(region)); |
Collaborator
There was a problem hiding this comment.
there is a "global" string that you need to handle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3
This change is