Skip to content

[ios] fix date/time input is not firing input event #3293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[ios] fix date/time input is not firing input event #3293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ios/sdk/WeexSDK/Sources/Component/WXEditComponent.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,6 +633,14 @@ -(void)fetchDatePickerValue:(NSString *)value
}
}

- (void)datePickerValueDidChange:(NSString *)value
{
self.text = value;
if (_inputEvent) {
[self fireEvent:@"input" params:@{@"value":[self text]} domChanges:@{@"attrs":@{@"value":[self text]}}];
}
}

#pragma mark UITextFieldDelegate

- (BOOL)textFieldShouldBeginEditing:(UITextField *)textField{
Expand Down
1 change: 1 addition & 0 deletions ios/sdk/WeexSDK/Sources/Manager/WXDatePickerManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
@protocol WXDatePickerManagerDelegate <NSObject>
@optional
- (void)fetchDatePickerValue:(NSString *)value;
- (void)datePickerValueDidChange:(NSString *)value;
@end

@interface WXDatePickerManager : NSObject
Expand Down
14 changes: 14 additions & 0 deletions ios/sdk/WeexSDK/Sources/Manager/WXDatePickerManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ - (instancetype)init
CGRect pickerFrame = CGRectMake(0, 44, [UIScreen mainScreen].bounds.size.width, WXPickerHeight-44);
datePicker.backgroundColor = [UIColor whiteColor];
datePicker.frame = pickerFrame;
[datePicker addTarget:self action:@selector(valueChanged:) forControlEvents:UIControlEventValueChanged];
UIToolbar *toolBar=[[UIToolbar alloc]initWithFrame:CGRectMake(0, 0, [UIScreen mainScreen].bounds.size.width, 44)];
[toolBar setBackgroundColor:[UIColor whiteColor]];
UIBarButtonItem* noSpace = [[UIBarButtonItem alloc] initWithBarButtonSystemItem:UIBarButtonSystemItemFixedSpace target:nil action:nil];
Expand Down Expand Up @@ -219,6 +220,19 @@ -(void)done:(id)sender

}

- (void)valueChanged:(id)sender
{
if ([self.delegate respondsToSelector:@selector(datePickerValueDidChange:)]) {
NSString *value = @"";
if ([_type isEqualToString:@"time"]) {
value = [WXUtility timeToString:self.datePicker.date];
} else if ([_type isEqualToString:@"date"]) {
value = [WXUtility dateToString:self.datePicker.date];
}
[self.delegate datePickerValueDidChange:value];
};
}

#pragma mark - UIGestureRecognizerDelegate
- (BOOL)gestureRecognizer:(UIGestureRecognizer *)gestureRecognizer shouldReceiveTouch:(UITouch *)touch {
if (self.datePickerView && [touch.view isDescendantOfView:self.datePickerView]) {
Expand Down