Skip to content

Conversation

songqing
Copy link
Contributor

What do these changes do?

When run this WCC algorithm with only one worker, the algorithm will only compute one iteration, so as to cause wrong result.
Fix by add ForceContinue() in PEval() when needed.

@songqing
Copy link
Contributor Author

@zhanglei1949 please help a review

Copy link
Collaborator

@zhanglei1949 zhanglei1949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 30.95%. Comparing base (7ec6d6c) to head (f97383b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4623      +/-   ##
==========================================
- Coverage   33.02%   30.95%   -2.07%     
==========================================
  Files         127      127              
  Lines       13299    13316      +17     
==========================================
- Hits         4392     4122     -270     
- Misses       8907     9194     +287     

see 28 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ec6d6c...f97383b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants