Skip to content

Allow filtering of console api methods #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow filtering of console api methods #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions stripify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ module.exports = function (file, opts) {

opts = opts || {}
opts.replacement = opts.replacement || opts.r || ''
opts.methods = opts.methods || opts.m || consoleApi

var data = ''

Expand All @@ -27,15 +28,15 @@ module.exports = function (file, opts) {

function parse (data, opts) {
return falafel(data, function (node) {
if (node.type !== 'DebuggerStatement' && (node.type !== 'CallExpression' || (!isConsoleLog(node.callee) && !isConsoleLogProto(node.callee)))) return
if (node.type !== 'DebuggerStatement' && (node.type !== 'CallExpression' || (!isConsoleMethod(node.callee, opts.methods) && !isConsoleMethodProto(node.callee, opts.methods)))) return
node.update(opts.replacement)
})
}

function isConsoleLogProto (node) {
function isConsoleMethodProto (node, methods) {
if (!node) return false
if (node.type !== 'MemberExpression') return false
return isProto(node.property) && isConsoleLog(node.object)
return isProto(node.property) && isConsoleMethod(node.object, methods)
}

var functionProtoMethods = [ 'apply', 'call' ]
Expand All @@ -44,8 +45,8 @@ function isProto (node) {
return node.type === 'Identifier' && (functionProtoMethods.indexOf(node.name) > -1)
}

function isConsoleLog (node) {
return isConsole(node) && isLog(node.property)
function isConsoleMethod (node, methods) {
return isConsole(node) && isMethod(node.property, methods)
}

function isConsole (node) {
Expand All @@ -54,8 +55,8 @@ function isConsole (node) {
return node.object.type === 'Identifier' && node.object.name === 'console'
}

var consoleApi = ['assert', 'count', 'debug', 'dir', 'error', 'exception', 'group', 'groupCollapsed', 'groupEnd', 'info', 'log', 'profile', 'profileEnd', 'time', 'timeEnd', 'trace', 'warn', 'table']

function isLog (node) {
return node.type === 'Identifier' && (consoleApi.indexOf(node.name) > -1)
function isMethod (node, methods) {
return node.type === 'Identifier' && (methods.indexOf(node.name) > -1)
}

var consoleApi = ['assert', 'count', 'debug', 'dir', 'error', 'exception', 'group', 'groupCollapsed', 'groupEnd', 'info', 'log', 'profile', 'profileEnd', 'time', 'timeEnd', 'trace', 'warn', 'table']
17 changes: 17 additions & 0 deletions test/expected/methods.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
console.assert();
console.count();
console.debug();
console.dir();
console.error();
console.exception();
console.group();
console.groupCollapsed();
console.groupEnd();
;
;
console.profile();
console.profileEnd();
console.time();
console.timeEnd();
console.trace();
console.warn();
17 changes: 17 additions & 0 deletions test/fixtures/methods.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
console.assert();
console.count();
console.debug();
console.dir();
console.error();
console.exception();
console.group();
console.groupCollapsed();
console.groupEnd();
console.info();
console.log();
console.profile();
console.profileEnd();
console.time();
console.timeEnd();
console.trace();
console.warn();
5 changes: 3 additions & 2 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ var stripify = require('../')

var files = fs.readdirSync(path.join(__dirname, 'fixtures'))
var testOpts = {
'replacement.js': {r: '(0)'}
'replacement.js': {r: '(0)'},
'methods.js': {methods: ['log', 'info']}
}

files.forEach(function (file) {
Expand All @@ -26,4 +27,4 @@ files.forEach(function (file) {
})
}))
})
})
})