Homework final 2 #13
Open
Homework final 2 #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimonl
approved these changes
Aug 31, 2021
| var conn net.Conn | ||
|
|
||
| /// connect with telegram bot | ||
| token, err := ReadToken("./telegram_token.json") |
There was a problem hiding this comment.
hardcoded parameters is bad practice
| ErrFunc(err) | ||
|
|
||
| updateConfig := tgbotapi.NewUpdate(0) | ||
| updateConfig.Timeout = 60 |
There was a problem hiding this comment.
the same thing - hardcoded parameters is evil.
|
|
||
| for update := range updates { | ||
| if update.Message != nil { | ||
| conn, _ = net.Dial("tcp", "127.0.0.1:8080") |
|
|
||
| id := update.Message.Chat.ID | ||
|
|
||
| if len(update.Message.Text) > 100 { |
There was a problem hiding this comment.
Why are you limiting message here?
| default: | ||
| message = "incorrect request" | ||
| } | ||
| conn.Write([]byte(message + "\v")) |
|
|
||
|
|
||
| func MakeUrl(city string)(string, error){ | ||
| KeyWeather, err := ReadToken("./weather_token.json") |
| return "", err | ||
| } | ||
|
|
||
| URL := "https://api.openweathermap.org/data/2.5/weather?q=" + |
| } | ||
|
|
||
| cityStr := strings.Replace(request, "/city ", "", 1) | ||
| url, _ := MakeUrl(cityStr) |
There was a problem hiding this comment.
if you declare func as (result, error) - why you don't handle error?
| } | ||
|
|
||
| InitDB() | ||
| err = AddDBRequest(cityStr, message) |
There was a problem hiding this comment.
you don't extract different layers in application. All in one file - handle requests, app logic, work with db.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.