Skip to content

Fix/4434 idle cpu - removing unused #if compile time conditionals #4438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 17, 2020
Merged

Fix/4434 idle cpu - removing unused #if compile time conditionals #4438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c06bedb
cleaned up IFDEFs for Full trust thread pool execution
Aaronontheweb May 26, 2020
b2b9f42
removed some more IFDEF code
Aaronontheweb May 26, 2020
1345aac
cleaned up more IFDEFs
Aaronontheweb May 26, 2020
f0d3684
Revert "cleaned up more IFDEFs"
Aaronontheweb May 26, 2020
163ca92
Revert "removed some more IFDEF code"
Aaronontheweb May 26, 2020
4c97c4a
Merge branch 'dev' into fix/4434-IdleCpu
Aaronontheweb Jun 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/core/Akka/Dispatch/AbstractDispatcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,9 +218,7 @@ private static DedicatedThreadPoolSettings ConfigureSettings(Config config)
/// </summary>
internal sealed class ThreadPoolExecutorServiceFactory : ExecutorServiceConfigurator
{
#if APPDOMAIN
private static readonly bool IsFullTrusted = AppDomain.CurrentDomain.IsFullyTrusted;
#endif

/// <summary>
/// TBD
Expand All @@ -229,10 +227,9 @@ internal sealed class ThreadPoolExecutorServiceFactory : ExecutorServiceConfigur
/// <returns>TBD</returns>
public override ExecutorService Produce(string id)
{
#if APPDOMAIN
if (IsFullTrusted)
return new FullThreadPoolExecutorServiceImpl(id);
#endif

return new PartialTrustThreadPoolExecutorService(id);
}

Expand Down
3 changes: 0 additions & 3 deletions src/core/Akka/Dispatch/Dispatchers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
using System.Threading.Tasks;
using Akka.Actor;
using Akka.Configuration;
using Akka.Configuration;
using Helios.Concurrency;
using ConfigurationFactory = Akka.Configuration.ConfigurationFactory;

Expand Down Expand Up @@ -45,7 +44,6 @@ protected ThreadPoolExecutorService(string id) : base(id)
}
}

#if UNSAFE_THREADING
/// <summary>
/// INTERNAL API
/// </summary>
Expand All @@ -68,7 +66,6 @@ public FullThreadPoolExecutorServiceImpl(string id) : base(id)
{
}
}
#endif

/// <summary>
/// INTERNAL API
Expand Down