-
Couldn't load subscription status.
- Fork 22
[Persistence] Add supervisor strategy to journal and snapshot options #602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
[Persistence] Add supervisor strategy to journal and snapshot options #602
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just assign a SupervisionStrategy directly?
|
Because the way it is set up in Akka, it requires a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the goal is to assign a supervisor strategy
- the
SupervisorConfiguratoror whatever it's called is a hack we have to have in order to get HOCON to work. - We can just do the
SupervisorStrategydirectly here and generate the configurator for it. That would be the DX-friendly way to do this.
|
Yes, but that is not how the supervisor strategy being loaded from HOCON the HOCON loader requires that the type being passed in as a |
|
We can't just "generate" a configurator because it still needs to be loaded from HOCON in the end. And as you said, "the SupervisorConfigurator or whatever it's called is a hack we have to have in order to get HOCON to work". You mean actually use code generator to make a class during compilation time? |
Changes
Add
JournalOptions.SupervisorStrategyandSnapshotOptions.SupervisorStrategyoptions that was added to Akka v1.5.42