Skip to content

fix(cmd/testnetify): pass config by pointer #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2025
Merged

fix(cmd/testnetify): pass config by pointer #2018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/testnet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,16 @@ type TestnetConfig struct {
func InitAkashAppForTestnet(
app *AkashApp,
db dbm.DB,
tcfg TestnetConfig,
tcfg *TestnetConfig,
) *AkashApp {
//
// Required Changes:
//

if tcfg == nil {
tmos.Exit("TestnetConfig cannot be nil")
}

var err error

defer func() {
Expand Down
4 changes: 2 additions & 2 deletions cmd/akash/cmd/app_creator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,9 @@ func (a appCreator) newTestnetApp(logger log.Logger, db dbm.DB, traceStore io.Wr
panic("app created from newApp is not of type AkashApp")
}

tcfg, valid := appOpts.Get(cflags.KeyTestnetConfig).(akash.TestnetConfig)
tcfg, valid := appOpts.Get(cflags.KeyTestnetConfig).(*akash.TestnetConfig)
if !valid {
panic("cflags.KeyTestnetConfig is not of type akash.TestnetConfig")
panic("cflags.KeyTestnetConfig is not of type *akash.TestnetConfig")
}

// Make modifications to the normal AkashApp required to run the network locally
Expand Down
10 changes: 4 additions & 6 deletions script/upgrades.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,12 +169,10 @@ trap_show() {
}

function cleanup() {
jb=$(jobs -p)

if [[ "$jb" != "" ]]; then
while IFS= read -r pid; do
# shellcheck disable=SC2086
kill $jb
fi
kill $pid
done < <(jobs -p)
}

trap_add EXIT 'cleanup'
Expand Down Expand Up @@ -365,7 +363,7 @@ function init() {
genesis_file=${valdir}/config/genesis.json
rm -f "$genesis_file"

$AKASH init --home "$valdir" "$(jq -rc '.moniker' <<<"$val")" >/dev/null 2>&1
$AKASH genesis init --home "$valdir" "$(jq -rc '.moniker' <<<"$val")" >/dev/null 2>&1

cat >"$valdir/.envrc" <<EOL
PATH_add "\$(pwd)/cosmovisor/current/bin"
Expand Down
Loading