-
Notifications
You must be signed in to change notification settings - Fork 254
chore: bump cli package #2014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump cli package #2014
Conversation
WalkthroughThe pull request updates Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
fixes tx unjail command Signed-off-by: Artur Troian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: network-upgrade
- GitHub Check: lint-shell
- GitHub Check: sims
- GitHub Check: build-bins
- GitHub Check: tests
- GitHub Check: release-dry-run
- GitHub Check: lint-go
- GitHub Check: coverage
- GitHub Check: build-macos
🔇 Additional comments (2)
go.mod (2)
49-49: Clarify the actual fix — the PR description doesn't match code changes.The version bump from v0.1.1 to v0.1.4 is confirmed, but the PR title claims "fixes tx unjail command" which isn't evident from these changes. The only unjail reference in the codebase is a flag for exporting jailed validators during state export (util/server/server.go:197), not a tx command. The git diff shows only a version bump and reorganization of the replace block; no implementation of an unjail fix.
Add a CHANGELOG entry documenting what this CLI version bump actually addresses, and update the PR description to accurately reflect the changes. Fill in the issue reference placeholder ("Closes: #XXXX") if applicable.
53-77: Fork maintenance risks confirmed; version conflicts absent.The review's durability concerns are partially valid:
The regen-network/protobuf fork is not actively maintained (latest release Jan 15, 2021) and the Cosmos SDK ecosystem has migrated to cosmos/gogoproto. The replace block comment correctly notes this fork should be "replaced by cosmos/gogoproto in future versions," indicating temporary status.
Akash completed a Cosmos SDK v0.53 upgrade in late October 2025 and announced a public evaluation to deprecate or migrate its Cosmos chain, which creates long-term maintenance uncertainty for the akash-network/cosmos-sdk fork.
The pinned goleveldb version (v1.0.1-0.20210819022825-2ae1ddf74ef7) is correct and required by Cosmos SDK for v0.53.x compatibility.
go mod verifypassed with no version conflicts detected.Action: The go.mod is currently stable, but plan a migration path away from the regen-network/protobuf fork to cosmos/gogoproto per the inline comment, and monitor Akash's chain deprecation evaluation for potential fork sunset timelines.
| gotest.tools/v3 v3.5.2 | ||
| pkg.akt.dev/go v0.1.5 | ||
| pkg.akt.dev/go/cli v0.1.1 | ||
| pkg.akt.dev/go/cli v0.1.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Complete the PR checklist before merge.
Per the PR author checklist, the following items are unchecked and should be addressed:
- ✗ Include the correct type prefix in PR title (currently
chore:— verify if this is a breaking change that requires!) - ✗ Provide a link to the relevant issue (PR description has placeholder
Closes: #XXXX) - ✗ Add a changelog entry to
CHANGELOG.md - ✗ Include necessary unit and integration tests (verify test coverage for the unjail command fix)
Completion of these items is required before this PR can be merged.
🤖 Prompt for AI Agents
In go.mod around line 49, the PR was opened without completing the author
checklist; update the PR title to use the correct type prefix (and add a `!` if
this is a breaking change), replace the placeholder "Closes: #XXXX" in the PR
description with the actual issue link/number, add a clear changelog entry for
the unjail command fix to CHANGELOG.md, and add/adjust unit and integration
tests to cover the unjail command fix (ensure test files are committed and CI
passes) before merging.
fixes
tx unjailcommandadds
validator-setcommand