Skip to content

Conversation

@rick-a-lane-ii
Copy link

@rick-a-lane-ii rick-a-lane-ii commented Oct 15, 2025

Description

WIP

Refactors the behavior of deployments and deployment groups when accounts are overdrawn. This is an initial update that will likely go through several iterations (within this PR and/or via multiple PRs).

While the current design is impressively clean, there are multiple use cases flowing through common code related to this refactor, and it's likely the design needs to be further updated with either interface changes and/or strategic use of options to improve readability, enhance overall flow control, and separate the functionality of different use cases.

This change is fairly rudimentary so far, but this establishes some sense of the issue at hand. Nor does this address all of the concerns listed in the issue (yet).

Comments welcome early (as always), but this will be progressing through multiple iterative stages, and may completely change shortly.

TODO

  • Refactor design (as necessary) to ensure multiple use cases all operate as expected.
  • Reconsider appropriate testing design/placement for all changes.
  • Add additional automated testing where appropriate.
  • Local development environment testing.
  • Ensure new lease creation works as stated in conjunction.
  • Ensure the escrow balance reflects appropriately.
  • Ensure the payment reflects appropriately.

Closes akash-network/support#368

Author Checklist

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

@coderabbitai
Copy link

coderabbitai bot commented Oct 15, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deployment/Deployment Groups Close When Funds Exhaust

1 participant