Skip to content

Conversation

Fireant456
Copy link

@Fireant456 Fireant456 commented Sep 22, 2022

Proposed changes in this pull request

documented recommended environment and steps to get up and running quickly based on our own experience and clarifications from Aiven support.

Type (put an x where ever applicable)

  • Bug fix: Link to the issue
  • Feature (Non-breaking change)
  • Feature (Breaking change)
  • Documentation Improvement
  • Other

Checklist

Please put an x against the checkboxes. Write a small comment explaining if its N/A (not applicable)

  • All the tests are passing after the introduction of new changes.
  • Added tests respective to the part of code I have written.
  • Added proper documentation where ever applicable (in code and README.md).

Optional extra information

We struggled greatly to get up and running with this tool locally in order to debug our migration we were attempting on the aiven cloud, had to clarify that Fedora was recommended by support and modify setup steps that were provided by the Readme.

I would love to see a docker container be released that allows users to spin up the container and start using aiven-db-migrate with a couple of commands.

@Fireant456 Fireant456 requested a review from a team as a code owner September 22, 2022 23:16
**Prerequistes**

Recommended to use **Fedora Linux Distrubution** or you might need to install additional packages/perform additional steps than those listed below
- Python 3.5 or newer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicates requirement above, could you remove it please from there?


**Initialization**
```
$ git clone https://github.com/Sonoran-Software/aiven-db-migrate.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link does not lead to the original version, it should be under aiven account.

- Python Pip
- Git
- make
- psycopg2-binary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If pip cmd is already in the example, for the quick start could have also specified the command how to install it.
pip install psycopg2-binary
Actually binary is not required, psycopg2 is required, but whether to install it as binary or not, it's up to the user.

Copy link
Contributor

@alexole alexole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants