Switched markdownlint config to stable MD rule IDs #3155
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Aug 25, 2025
There was a problem hiding this comment.
I'm fine with the rimraf usage, but removing the comments seems like a massive decrease in DX, and changing to rule IDs seems like it is a minor decrease in DX. Why is that needed at all? Those rule names can't change without a semver-major just like the IDs - they seem equally stable.
|
Deleting the fork renders the PR unrecoverable :-/ please don't do that in the future. |
actually it was a mistake , what now ? i don't know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the install scripts Windows-friendly by replacing Unix-only rm -rf with cross-platform rimraf and adding rimraf as a dev dependency. Cleaned and modernized markdownlint configuration by switching to canonical MD rule IDs and removing extraneous comment keys, preserving original linting intent. Lint now runs reliably across environments without behavioral changes.