Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

Conversation

@kmsheng
Copy link

@kmsheng kmsheng commented May 28, 2020

hypernova pollutes the global.Promise with bluebird's.
This will cause unwanted behaviors for application which uses other libraries that also use native Promise object.

This PR intends to remove direct assignment to global.Promise and keeps hypernova run as before by the followings:

  1. Copy Promise related declaration code from environment.js to promise.js
  2. Add import Promise statements to files which invoke Promise which will feed them with bluebird's Promise as before
  3. remove Promise related code and global assignment from environment.js

@espretto
Copy link

espretto commented Jan 9, 2023

Related issues: #201 , #135

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants