crypto: bound copies and sample reads in header protection paths #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeaderProtection_apply and HeaderProtection_remove copied untrusted input into a fixed 1500-byte scratch buffer without verifying sizes, enabling heap OOB writes when header_len + payload_len (apply) or pn_offset + 4 (remove) exceeded the buffer. They also computed the header-protection sample without ensuring SAMPLE_LENGTH bytes were available, risking OOB reads. - apply: validate header_len >= pn_length, (header_len + payload_len) <= 1500, and payload_len >= (PACKET_NUMBER_LENGTH_MAX - pn_length) + SAMPLE_LENGTH. - remove: validate pn_offset within buffer bounds, input has at least pn_offset + PACKET_NUMBER_LENGTH_MAX bytes, and has SAMPLE_LENGTH following for the sample. Signed-off-by: Joshua Rogers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HeaderProtection_apply and HeaderProtection_remove copied untrusted input into a fixed 1500-byte scratch buffer without verifying sizes, enabling heap OOB writes when header_len + payload_len (apply) or pn_offset + 4 (remove) exceeded the buffer. They also computed the header-protection sample without ensuring SAMPLE_LENGTH bytes were available, risking OOB reads.