Skip to content

Conversation

alvarolopez
Copy link
Contributor

No description provided.

Copy link
Contributor

@IgnacioHeredia IgnacioHeredia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alvarolopez
Question: is there a reason why we are not running qa for all branches?

                 anyOf {
                     branch 'cicd'
                     branch 'main'
                     branch 'master'
                     branch 'test'
                     branch 'dev'
                     branch 'release/*'
                 }

Is it to save compute?

Because we need to think about how we are going to deal with the following usecases:

  • development environment: we are building tens of different tags (multiple Tensorflow versions, multiple Pytorch versions, etc) @vykozlov

  • demo app: we have branches main and return-files which both need to be built.

  • federated server: we have branches main and tokens which both need to be built.

I get that building images for every branch creates lots of noise. In fact demo app currently has multiples branches that I do not want to build.

Proposal: maybe have a build/* or deploy/* naming pattern (similar to the release one) that will trigger the qa?

One could abuse the current release/* pattern, but I think it might be cleaner to have another one.

What do you think?

@alvarolopez alvarolopez force-pushed the master branch 3 times, most recently from 2b5588b to 3db8a90 Compare August 9, 2024 11:45
@alvarolopez alvarolopez marked this pull request as draft August 13, 2024 08:12
@alvarolopez
Copy link
Contributor Author

@alvarolopez Question: is there a reason why we are not running qa for all branches?

                 anyOf {
                     branch 'cicd'
                     branch 'main'
                     branch 'master'
                     branch 'test'
                     branch 'dev'
                     branch 'release/*'
                 }

Is it to save compute?

This came from the old Jenkinsfile.

Because we need to think about how we are going to deal with the following usecases:

* development environment: we are building tens of different tags (multiple Tensorflow versions, multiple Pytorch versions, etc) @vykozlov

* [demo app](https://github.com/ai4os-hub/ai4os-demo-app/branches): we have branches `main` and `return-files` which both need to be built.

* [federated server](https://github.com/deephdc/federated-server/branches): we have branches `main` and `tokens`  which both need to be built.

I get that building images for every branch creates lots of noise. In fact demo app currently has multiples branches that I do not want to build.

Proposal: maybe have a build/* or deploy/* naming pattern (similar to the release one) that will trigger the qa?

One could abuse the current release/* pattern, but I think it might be cleaner to have another one.

What do you think?

I think that we should define a pattern of what to build, for sure, lets discuss this offline and we can implement this in a different change.

Enable GitHub and Zenodo integration for every repo
This change gets the Zenodo DOI for a given repository. As there is no
way to programatically retrieve a Zenodo record for a GitHub repo, this
change searches for the GitHub repo URL and gets the first result. Then,
it creates a new branch, pushes it, and creates a pull request to the
original repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants