Skip to content

solution from styk-tv #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

solution from styk-tv #93

wants to merge 15 commits into from

Conversation

styk-tv
Copy link

@styk-tv styk-tv commented Jul 15, 2019 •
edited
Loading

This solution passes 18 original tests requested by defined requirements.

This solution is pushed as PR back to original repo for the purpose of travis autotest. Original solution development history in this repo

  • checked in PhantomJS, Chrome and Firefox (node 3 tests in 3 browsers = 9 * tests success)
  • iojs could be removed since io.js has merged with the Node.js project again. There won't be any further io.js releases. All of the features in io.js are available in Node.js v4 and above. Left in tact because required by tests. (iois 3 tets in 3 browsers = 9 * test success)
  • overall suggestion to drop PhantomJS as two major bugs delayed success of all tests (described in test files)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@styk-tv