Skip to content

addDependency function on controllers to make it easier to add cleaned up things like events #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

addDependency function on controllers to make it easier to add cleaned up things like events #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions src/controller/ApplicationController.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import Debug from 'debug';
import { randomId } from '../utils/randomId';
import CAF from 'caf';
import { cloneDeep } from 'lodash';
import { observe } from '..';

const debug = Debug('framework:controller');

Expand All @@ -30,6 +31,8 @@ type GetControllerConstructor<T> = { new (): T };
type GetControllerProps<T extends ApplicationControllerConstructor<any>> =
T extends ApplicationControllerConstructor<infer P> ? P : never;

export type DependencyCallback = () => void | Promise<void>;

/**
* General rules to follow for using controllers:
*
Expand Down Expand Up @@ -162,6 +165,34 @@ class ApplicationController<
*/
internalDestroy() {
this.destroy();
this.deferredDestroyCallbacks.forEach(([_name, callback]) => callback());
this.deferredDestroyCallbacks = [];
}

private deferredDestroyCallbacks: [string, DependencyCallback][] = [];

resolveDependency(name: string) {
const callbacks = this.deferredDestroyCallbacks.filter(([n]) => n === name);
callbacks.forEach(([_, callback]) => callback());
this.deferredDestroyCallbacks = this.deferredDestroyCallbacks.filter(([n]) => n !== name);
}

addDependency(name: string, callback: DependencyCallback): void;
addDependency(callback: DependencyCallback): void;
addDependency(nameOrCallback: string | DependencyCallback, callback?: DependencyCallback) {
if (typeof nameOrCallback === "string") {
if (!callback) throw new Error("Callback is required");
this.deferredDestroyCallbacks.push([nameOrCallback, callback]);
} else if (typeof nameOrCallback === "function") {
this.deferredDestroyCallbacks.push(["unknown", nameOrCallback]);
} else {
throw new Error("Invalid arguments");
}
}

observe(callback: () => void, options: Parameters<typeof observe>[1] = {}) {
const observer = observe(callback, options);
this.addDependency(() => observer());
}

/**
Expand Down