Add support to account id, payment type etc. #62
Conversation
|
@agileware-justin , @agileware-fj Can you please take a look? |
|
@sunilpawar we have had a look, thanks. |
| // finished before you did, so your work was not saved. | ||
| $invoiceExiting = $this->getInvoiceFromQBO($record); | ||
| $accountsInvoice->SyncToken = $invoiceExiting->SyncToken; | ||
|
|
There was a problem hiding this comment.
Have always been a little apprehensive about doing this in the push function, however on balance of things I guess if an important change had been made, it would have been pulled in during the InvoicePull call already anyway.
Approved
| 'name' => "quickbooks_account_id", | ||
| 'group' => 'civiquickbooks', | ||
| ]); | ||
| $paymentInstrument = CRM_Contribute_BAO_Contribution::buildOptions('payment_instrument_id', 'create'); |
There was a problem hiding this comment.
I think buildOptions is deprecated, this could be an API call?
| } | ||
| } | ||
|
|
||
| // set Account ID |
There was a problem hiding this comment.
My understanding is that on the Quickbooks side, each product or service should have an Income account set, and we should defer where the payments go to this.
Is there a particular reason for having a setting for one particular income account that overrides this behaviour? It doesn't sound like the correct approach
Additional changes: