[ refactor ] Data.Fin.Properties.decFinSubset
#2793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacquesCarette
approved these changes
Aug 1, 2025
MatthewDaggitt
previously requested changes
Aug 2, 2025
JacquesCarette
approved these changes
Aug 2, 2025
jamesmckinna
changed the title
Data.Fin.Properties.decFinSubsetData.Fin.Properties.decFinSubset
|
@MatthewDaggitt can you re-review ahead of a possible merge? |
jamesmckinna
commented
Oct 11, 2025
|
Hmm... some weird sync error. Have fast-forwarded with |
jamesmckinna
commented
Oct 26, 2025
| dec[Q⊆P] : Dec (Q ⊆ P) | ||
| dec[Q⊆P] with Q? zero | ||
| ... | no ¬q₀ = map′ (cons (contradiction′ ¬q₀)) Q⊆P⇒Q⊆ₛP ih | ||
| ... | yes q₀ = map′ (uncurry (cons ∘ const)) < _$ q₀ , Q⊆P⇒Q⊆ₛP > (P? q₀ ×-dec ih) |
There was a problem hiding this comment.
Note to self: this will need fixing if and when #2843 gets merged!
jamesmckinna
dismissed
MatthewDaggitt’s stale review
Matthew,
I fixed the variable declarations for Pred and Rel, so I'm taking your "Otherwise I approve" at face value.
Merging now.
|
Rebasing against |
jamesmckinna
added a commit
to jamesmckinna/agda-stdlib
that referenced
this pull request
Oct 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #2744 . Almost purely cosmetic:
variables. NB. cf. Fix breaking introduction of variable inSemiring.Primality#2774 for problems with non-prenex use of such thingsall?to avoid use ofdecFinSubset(idiotic complexity blow-up)CHANGELOGNB.
DecFinSubset.consmakes successful use ofλ-and$-, but I don't seem able to do so forQ⊆P⇒Q⊆ₛPthanks to unsolved metas!?flip contradiction! [ add ] new name forflipped version ofRelation.Nullary.Negation.Core.contradiction#2784