Dry-run balance fixes #1882
Draft
Dry-run balance fixes #1882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: DRY_RUN_ACCOUNT not exported anymore Use `ak_11111111111111111111111111111111273Yts` or define an own address.
BREAKING CHANGE: On-chain balance used for accounts in dry-run Before it was an on-chain balance plus 1e+35.
davidyuk
force-pushed
the
feature/fix-dry-run
branch
2 times, most recently
from
92ce62d to
68f7200
Compare
BREAKING CHANGE: `txDryRun` accepts account balances in options
Apply a change
```diff
-txDryRun(tx, address)
+txDryRun(tx, { addAccounts: [{ address, amount: n }] })
```
Where `amount` is a value in aettos to add to the on-chain balance of that account.
Alternatively, `addAccounts` can be omitted to use the on-chain balance
```js
txDryRun(tx)
```
Where `amount` is a value in aettos to add to the on-chain balance of that account.
davidyuk
force-pushed
the
feature/fix-dry-run
branch
from
68f7200 to
20874e0
Compare
davidyuk
force-pushed
the
develop
branch
2 times, most recently
from
7ac314e to
4109373
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1881 closes #1860
This PR is supported by the Æternity Crypto Foundation