refactor: Remove Pre 5 XDR related code [KO-458] #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
abhishekdwivedi3060
commented
Oct 29, 2025
abhishekdwivedi3060
commented
- Removed Pre 5 XDR related code
- Removed old Pre 5 XDR related test-cases and update sample yamls
abhishekdwivedi3060
requested review from
jwalantmodi05 and
tanmayja
as code owners
abhishekdwivedi3060
changed the title
tanmayja
approved these changes
Oct 30, 2025
| {{- if .WorkDir }} | ||
| # Create required directories. | ||
| DEFAULT_WORK_DIR="/workdir/filesystem-volumes{{.WorkDir}}" | ||
| REQUIRED_DIRS=("smd" "usr/udf/lua" "xdr") |
Contributor
There was a problem hiding this comment.
We weren’t updating these scripts anymore. right?
Collaborator
Author
There was a problem hiding this comment.
Yes, not for the new changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.