-
Couldn't load subscription status.
- Fork 235
feat(field-label): added and implemented field-label mixin #5799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nikkimk
wants to merge
87
commits into
nikkimk/form-field-mixin
Choose a base branch
from
nikkimk/1042-form-mixins
base: nikkimk/form-field-mixin
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
87 commits
Select commit
Hold shift + click to select a range
12f2fc9
feat(label): init field label mixin
nikkimk b6ea53b
feat(textfield): updated textfiled docs to use label mixin
nikkimk 6117e6b
feat(field-label): added mixin to package exports
nikkimk d5448f1
feat(field-label): added optional slot name for rendering label slot
nikkimk cf1c9d7
docs(textfield): implemented label mixin in stories
nikkimk 743d553
test(textfield): added test for slotted label
nikkimk c386f09
feat(textfield): added default slot observer for label changes
nikkimk e812721
test(textfield): added tests for slotted label
nikkimk 5be1715
docs(number-field): updated number field docs based on text field lab…
nikkimk 56954ed
docs(number-field): updated stories with slotted label
nikkimk b5bdd62
docs(color-field): updated docs with slotted label
nikkimk d6dde5b
feat(field-label): updated interface to include optional slot name fo…
nikkimk e0e85c5
feat(combobox): added label slot to combobox
nikkimk 3c226f8
docs(combobox): added slotted label to docs
nikkimk 183218c
test(combobox): updates tests with slotted label
nikkimk c408b4e
fix(combobox): fixed combobox field id for label
nikkimk 84c67c3
feat(field-label): added label slot change handler to mixin
nikkimk 8822ec1
feat(combobox): added slot change handlers
nikkimk 4868c82
feat(field-label): hide field label if not used
nikkimk 9cdc838
feat(textfield): use field label mixin to observe slot
nikkimk d36080d
feat(combobox): use field label mixin to observe slot
nikkimk c304d57
feat(combobox): added placeholder
nikkimk da60cf4
fix(textfield): fixed issue with detecting slot content
nikkimk c40127f
fix(field-label): fixed issue with slot content detection in text field
nikkimk 9717285
test(textfield): removed unneccessary id attribute
nikkimk 0ffa462
fix(fieldl-label): fixed mixin to allow slot naming
nikkimk 4ac3c92
feat(combobox): updated combobox, stories and tests for field label m…
nikkimk dd22117
fix(field-label): corrected linting issues
nikkimk 4263db4
fix(menu): MenuItem focus stealing from input elements on mouseover (…
Rajdeepc 58fab11
fix(field-label): made field id optional for picker
nikkimk 6a22c11
fix(field-label): made field id optional for picker
nikkimk 93289a4
feat(picker): added field label mixin to pciker and picker stories
nikkimk f0b3a39
fix(textfiled): fixed element name in warning
nikkimk 462f5bb
fix(combobox): fixed element name in warning
nikkimk 8d7b1ad
docs(picker): updated stories
nikkimk 3934124
feat(picker): added field label mizin to picker without affecting pic…
nikkimk 56e2e38
docs(textfield): documented default label slot
nikkimk b776c24
feat(picker): reverting changes until picker is refactored
nikkimk 87cd4fb
feat(picker): reverting changes until picker is refactored
nikkimk c874038
feat(picker): reverting changes until picker is refactored
nikkimk 6037e88
feat(picker): reverting changes until picker is refactored
nikkimk 2ce98c9
feat(picker): reverting changes until picker is refactored
nikkimk d1996b0
feat(picker): reverting changes until picker is refactored
nikkimk 8a917a4
feat(picker): reverting changes until picker is refactored
nikkimk fbf91db
feat(picker): reverting changes until picker is refactored
nikkimk 2a11769
feat(picker): reverting changes until picker is refactored
nikkimk f573755
feat(picker): reverting changes until picker is refactored
nikkimk 28b0054
docs(textfield): updated docs with label examples
nikkimk c376488
docs(textfield): fixed issue with tabs
nikkimk 4cc0120
Merge branch 'main' into nikkimk/1042-form-mixins
nikkimk f0b2a3c
test(textfield): updated test warning text to match revised warning text
nikkimk 29947da
docs(combobox): added label and placeholder sections to docs
nikkimk 13e854a
docs(textfield): changed tabs label
nikkimk 4d45feb
docs(number-field): updated docs with a label section
nikkimk 78fc419
chore(changeset): added changsets
nikkimk 41f08c9
docs(field-label): added field-label-mixin docs
nikkimk 9ed1dd5
Apply suggestion from @nikkimk
nikkimk 2eabaed
feat(picker): revert changes
nikkimk feb1241
feat(picker): revert changes
nikkimk dc4e856
chore: updated changesets
nikkimk ccafa69
docs(color-field): added label docs
nikkimk 73b9dc5
chore: updated changesets
nikkimk 9ceeade
docs(combobox): fixed typo
nikkimk 9b04178
docs(field-label): added JS Docs to mixin
nikkimk 59abba0
chore: linting fixes
nikkimk fd99e5d
docs(combobox): fixed typo
nikkimk a3c011f
chore: dropped changeset
nikkimk e4bf6ce
docs(color-field): fixed typo
nikkimk 0b553fe
chore(combobox): fixed typo
nikkimk bbd4cdb
docs(combobox): added side-aligned to story
nikkimk 7f5f325
docs(combobox): fixed typo
nikkimk d3ae4ed
docs(combobox): fixed typo
nikkimk 65d97ac
docs(field-label): added links to mixin docs
nikkimk cf8345c
docs(field-label): added code type in mixin docs
nikkimk e7c1e63
docs(field-label): added code type in mixin docs
nikkimk 25bf661
fix(textfield): simiplified styles getter
nikkimk 798b1be
fix(textfield): simplified attribute
nikkimk 8222010
fix(textfield): simplified attribute
nikkimk d189d44
docs(field-label): added more detail to mixin docs
nikkimk 8eaa3bd
docs(field-label): added more detail to field label mixin docs
nikkimk dd27c32
fix(field-label): fixed inherited styles in mixin
nikkimk 2d2c653
fix(field-label): set side-aligned property to optional
nikkimk 55f0104
fix(field-label): added override to styles getter
nikkimk e6cd27d
fix(field-label): field id should be required
nikkimk ed3418c
fix(field-label): reverted styles changes to mixin
nikkimk cb4d007
fix(textfield): fixed styles array
nikkimk f24e789
fix(textfield): ensure super styles are CSSResultArray
nikkimk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@spectrum-web-components/number-field': minor | ||
| --- | ||
|
|
||
| **Added**: slotted visible label to resolve cross-root ARIA issues (Before: `<sp-field-label for="number">Label</sp-field-label><sp-number-field id="number"></sp-number-field>` / After: `<sp-number-field>Label</sp-number-field>`) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@spectrum-web-components/field-label': minor | ||
| --- | ||
|
|
||
| **Added**: field label mixin to insert a label in a component's shadow DOM to resolve cross-root ARIA issues (`export class FormField extends FieldLabelMixin(SpectrumElement, 'label')` to apply mixin with a `label` slot to a class and `this.renderFieldLabel('field_id')` to render a field label for an element with `id="field_id"`) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@spectrum-web-components/combobox': minor | ||
| --- | ||
|
|
||
| **Added**: slotted visible label to resolve cross-root ARIA issues (Before: `<sp-field-label for="combo">Label</sp-field-label><sp-combobox id="combo"></sp-combobox>` / After: `<sp-combobox><span slot="field-label">Label</span></sp-combobox>`) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@spectrum-web-components/textfield': minor | ||
| --- | ||
|
|
||
| **Added**: slotted visible label to resolve cross-root ARIA issues (Before: `<sp-field-label for="text">Label</sp-field-label><sp-textfield id="text"></sp-textfield>` / After: `<sp-textfield>Label</sp-textfield>`) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@spectrum-web-components/color-field': minor | ||
| --- | ||
|
|
||
| **Added**: slotted visible label to resolve cross-root ARIA issues (Before: `<sp-field-label for="color">Label</sp-field-label><sp-color-field id="color"></sp-color-field>` / After: `<sp-color-field>Label</sp-color-field>`) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.