- 
                Notifications
    You must be signed in to change notification settings 
- Fork 207
feat(checkbox): remove modifiers from the API [SWC-1264] #4287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: spectrum-two
Are you sure you want to change the base?
feat(checkbox): remove modifiers from the API [SWC-1264] #4287
Conversation
| 
 | 
| Name | Type | 
|---|---|
| @spectrum-css/alertdialog | Major | 
| @spectrum-css/asset | Major | 
| @spectrum-css/assetcard | Major | 
| @spectrum-css/assetlist | Major | 
| @spectrum-css/avatar | Major | 
| @spectrum-css/badge | Major | 
| @spectrum-css/breadcrumb | Major | 
| @spectrum-css/checkbox | Major | 
| @spectrum-css/divider | Major | 
| @spectrum-css/miller | Major | 
| @spectrum-css/page | Major | 
| @spectrum-css/well | Major | 
| @spectrum-css/bundle | Patch | 
| @spectrum-css/preview | Patch | 
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
| 📚 Branch previewPR #4287 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-4287/index.html. | 
| File metricsSummaryTotal size: 1.40 MB* 
 checkbox
 * An ASCII character in UTF-8 is 8 bits or 1 byte. | 
8b60b1f    to
    f5bd5e5      
    Compare
  
    f5bd5e5    to
    769dcc3      
    Compare
  
    86bc092    to
    71a231f      
    Compare
  
    1b177dc    to
    1617329      
    Compare
  
    14740cb    to
    857bd63      
    Compare
  
    76dc1c0    to
    17dce53      
    Compare
  
    | @media (forced-colors: active) { | ||
| --spectrum-checkbox-control-color: Highlight; | ||
| } | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected nesting depth to be no more than 3
| @media (forced-colors: active) { | ||
| --spectrum-checkbox-control-color: Highlight; | ||
| } | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected nesting depth to be no more than 3
17dce53    to
    68bb425      
    Compare
  
    
Description
This update removes
--mod-checkbox-*custom property hooks per SWC-1264, see also the RFC for extensible styling. Class selectors and variants remain unchanged; stories were refreshed to match the current API.--mod-checkbox-*custom property hooks.Breaking change: the
--mod-checkbox-*override layer is removed. Consumers should set--spectrum-checkbox-*variables directly where customization as needed.Related issue(s)
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesValidation steps
spectrum-twobaseline.Regression testing
Validate:
The documentation pages for at least two other components are still loading, including:
If components have been modified, VRTs have been run on this branch: