Skip to content

Conversation

@castastrophe
Copy link
Collaborator

@castastrophe castastrophe commented Oct 22, 2025

Description

This update removes --mod-checkbox-* custom property hooks per SWC-1264, see also the RFC for extensible styling. Class selectors and variants remain unchanged; stories were refreshed to match the current API.

  • Remove all --mod-checkbox-* custom property hooks.
  • Reduces unnecessary re-mapping of custom properties in favor of using them directly

Breaking change: the --mod-checkbox-* override layer is removed. Consumers should set --spectrum-checkbox-* variables directly where customization as needed.

Related issue(s)

  • fixes SWC-1264

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes (or confirmed existing coverage is sufficient for styling-only changes).
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a GitHub Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are passing or approved

Validation steps

  • No visual or behavioral changes compared to the current spectrum-two baseline.

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:

    • The pages render correctly, are accessible, and are responsive.
  2. If components have been modified, VRTs have been run on this branch:

    • VRTs have been run and looked at.
    • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

@castastrophe castastrophe added run_vrt For use on PRs looking to kick off VRT ready-for-review S2 Spectrum 2 labels Oct 22, 2025
@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2025

⚠️ No Changeset found

Latest commit: 68bb425

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 14 packages
Name Type
@spectrum-css/alertdialog Major
@spectrum-css/asset Major
@spectrum-css/assetcard Major
@spectrum-css/assetlist Major
@spectrum-css/avatar Major
@spectrum-css/badge Major
@spectrum-css/breadcrumb Major
@spectrum-css/checkbox Major
@spectrum-css/divider Major
@spectrum-css/miller Major
@spectrum-css/page Major
@spectrum-css/well Major
@spectrum-css/bundle Patch
@spectrum-css/preview Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@castastrophe castastrophe added size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. and removed ready-for-review labels Oct 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2025

📚 Branch preview

PR #4287 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-4287/index.html.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2025

File metrics

Summary

Total size: 1.40 MB*

Package Size Minified Gzipped
checkbox 12.25 KB 11.53 KB 1.94 KB

checkbox

Filename Head Minified Gzipped Compared to base
index.css 12.25 KB 11.53 KB 1.94 KB 🟢 ⬇ 7.19 KB
metadata.json 5.29 KB - - 🟢 ⬇ 5.25 KB
* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@castastrophe castastrophe force-pushed the castastrophe/feat-checkbox-modifier-removal branch 5 times, most recently from 8b60b1f to f5bd5e5 Compare October 23, 2025 15:24
@castastrophe castastrophe self-assigned this Oct 23, 2025
@castastrophe castastrophe force-pushed the castastrophe/feat-checkbox-modifier-removal branch from f5bd5e5 to 769dcc3 Compare October 23, 2025 16:03
@castastrophe castastrophe force-pushed the spectrum-two branch 2 times, most recently from 86bc092 to 71a231f Compare October 27, 2025 15:25
@castastrophe castastrophe force-pushed the castastrophe/feat-checkbox-modifier-removal branch 3 times, most recently from 1b177dc to 1617329 Compare October 27, 2025 17:32
@castastrophe castastrophe force-pushed the castastrophe/feat-checkbox-modifier-removal branch 5 times, most recently from 76dc1c0 to 17dce53 Compare October 29, 2025 13:40
Comment on lines +205 to +207
@media (forced-colors: active) {
--spectrum-checkbox-control-color: Highlight;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [stylelint] <max-nesting-depth> reported by reviewdog 🐶
Expected nesting depth to be no more than 3

Comment on lines +213 to +215
@media (forced-colors: active) {
--spectrum-checkbox-control-color: Highlight;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [stylelint] <max-nesting-depth> reported by reviewdog 🐶
Expected nesting depth to be no more than 3

@castastrophe castastrophe force-pushed the castastrophe/feat-checkbox-modifier-removal branch from 17dce53 to 68bb425 Compare October 29, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run_vrt For use on PRs looking to kick off VRT S2 Spectrum 2 size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants