Skip to content

Conversation

mpatters72
Copy link

Description

  • Adds optional app_grp parameter to enable organizing gitops files by application groups cloud/**app_grp**/namespace/cluster (eg all the backend team apps) as opposed to cloud/namespace/cluster alone.

Related Issue

#188

Motivation and Context

  • Helps with maintaining CODEOWNERS at lower level for approvals on gitops PRs.

  • Allows for auto-generating ArgoCD applications based on folder path ArgoCD Git Generators Directory when new gitops folders/files are added to directories

How Has This Been Tested?

Added tests to this repo. It correctly added additional folder in path when parameter was added and did not add it when it was not added.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • [x ] I have added tests to cover my changes.
  • [x ] All new and existing tests passed.

@kzadorozhny
Copy link
Member

What is the reason behind introducing the the app_grp parameters instead of setting the gitops_path to cloud/<app_grp>?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants