Skip to content

fix: avoid triggering onClick on disabled links #8828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 10, 2025
Merged

fix: avoid triggering onClick on disabled links #8828

merged 4 commits into from
Sep 10, 2025
+30 −4

Conversation

lixiaoyan
Copy link
Contributor

Closes #8827

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

snowystinger
snowystinger previously approved these changes Sep 10, 2025
View reviewed changes
Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Was this not testable in jest?

@lixiaoyan
Copy link
Contributor Author

@snowystinger Hi, I moved the checking code to the usePress hook and added the tests.

reidbarber
reidbarber previously approved these changes Sep 10, 2025
View reviewed changes
Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snowystinger snowystinger added this pull request to the merge queue Sep 10, 2025
Merged via the queue into adobe:main with commit 3cdd953 Sep 10, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snowystinger snowystinger snowystinger approved these changes

@reidbarber reidbarber reidbarber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: onClick should not be triggered on disabled links
3 participants
@lixiaoyan @snowystinger @reidbarber