Skip to content

fix(s2): make avatar-only action button have square dimension #8400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 18, 2025
Merged

fix(s2): make avatar-only action button have square dimension #8400

merged 7 commits into from
Jun 18, 2025
+28 −2

Conversation

reidbarber
Copy link
Member

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Jun 16, 2025

Build successful! 🎉

snowystinger
snowystinger reviewed Jun 16, 2025
View reviewed changes
@reidbarber reidbarber changed the title fix(s2): remove border radius of avatar in avatar-only action button fix(s2): make avatar-only action button have square dimension Jun 16, 2025
@rspbot
Copy link

rspbot commented Jun 17, 2025

Build successful! 🎉

@rspbot
Copy link

rspbot commented Jun 17, 2025

Build successful! 🎉

yihuiliao
yihuiliao previously approved these changes Jun 17, 2025
View reviewed changes
snowystinger
snowystinger reviewed Jun 17, 2025
View reviewed changes
snowystinger
snowystinger previously approved these changes Jun 17, 2025
View reviewed changes
devongovett
devongovett requested changes Jun 18, 2025
View reviewed changes
Copy link
Member

@devongovett devongovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

it looks off center. Looks like the avatar has negative margin on it?

@reidbarber reidbarber dismissed stale reviews from snowystinger and yihuiliao via e4fae5b June 18, 2025 15:11
@rspbot
Copy link

rspbot commented Jun 18, 2025

Build successful! 🎉

devongovett
devongovett reviewed Jun 18, 2025
View reviewed changes
@rspbot
Copy link

rspbot commented Jun 18, 2025

Build successful! 🎉

@reidbarber reidbarber added this pull request to the merge queue Jun 18, 2025
Merged via the queue into main with commit a5876d2 Jun 18, 2025
30 checks passed
@reidbarber reidbarber deleted the s2-avatar-radius-in-actionbutton branch June 18, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

@snowystinger snowystinger snowystinger approved these changes

@yihuiliao yihuiliao yihuiliao left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@reidbarber @rspbot @devongovett @snowystinger @yihuiliao