Skip to content

chore: Use inert in ariaHideOutside #8372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

devongovett
Copy link
Member

Reverts #8371

@LFDanLu
Copy link
Member

LFDanLu commented Jun 10, 2025

One bug found was that hovering a S2 SubmenuTrigger causes a focus ring to appear around the submenu that appears

@rspbot
Copy link

rspbot commented Jun 10, 2025

Build successful! 🎉

@rspbot
Copy link

rspbot commented Jun 10, 2025

## API Changes

@react-aria/overlays

/@react-aria/overlays:ariaHideOutside

 ariaHideOutside {
   targets: Array<Element>
-  root: any
+  options?: AriaHideOutsideOptions | Element
   returnVal: undefined
 }

@react-spectrum/overlays

/@react-spectrum/overlays:Overlay

 Overlay {
   children: ReactNode
   container?: Element
   disableFocusManagement?: boolean
   isKeyboardDismissDisabled?: boolean
   isOpen?: boolean
   nodeRef: MutableRefObject<HTMLElement | null>
   onEnter?: () => void
   onEntered?: () => void
   onEntering?: () => void
   onExit?: () => void
   onExited?: () => void
   onExiting?: () => void
+  shouldContainFocus?: boolean
 }

Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know we found some things, but happy to get back in to work on more

@filipw01
Copy link
Contributor

@devongovett While you're deeper in the topic of ariaHideOutside, could you take a look at this issue? #8268 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants