Skip to content

feat: allow dom props on alert dialog. add test ids to alert dialog buttons #8370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 17, 2025

Conversation

snow893
Copy link
Contributor

@snow893 snow893 commented Jun 9, 2025

Closes #8369

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Check storybook entry

🧢 Your Project:

@snow893 snow893 changed the title 8369: allow dom props on alert dialog and buttons in it fix: allow dom props on alert dialog and buttons in it Jun 9, 2025
@snow893 snow893 changed the title fix: allow dom props on alert dialog and buttons in it feat: allow dom props on alert dialog and buttons in it Jun 9, 2025
@snow893 snow893 changed the title feat: allow dom props on alert dialog and buttons in it feat: allow dom props on alert dialog. add test ids to alert dialog buttons Jun 11, 2025
Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the team will need to discuss what kind of testids we'll want to provide in the future but hopefully we'll preserve the naming structure you've set up here.

@LFDanLu LFDanLu added this pull request to the merge queue Jun 17, 2025
Merged via the queue into adobe:main with commit 18c3e3c Jun 17, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AlertDialog doesn't support data-testid
3 participants