Skip to content

chore: remove unused searchwithin #8338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

chore: remove unused searchwithin #8338

merged 1 commit into from
Jun 4, 2025

Conversation

snowystinger
Copy link
Member

Closes

A component that was never finished, never left alpha, and doesn't have any downloads. Just removing from the repo so we don't have to maintain the old code.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Jun 3, 2025

Build successful! 🎉

@rspbot
Copy link

rspbot commented Jun 3, 2025

## API Changes

tmp/dist/base-api/@react-spectrum/searchwithin

/tmp/dist/base-api/@react-spectrum/searchwithin:SearchWithin

-SearchWithin {
-  UNSAFE_className?: string
-  UNSAFE_style?: CSSProperties
-  alignSelf?: Responsive<'auto' | 'normal' | 'start' | 'end' | 'center' | 'flex-start' | 'flex-end' | 'self-start' | 'self-end' | 'stretch'>
-  aria-describedby?: string
-  aria-details?: string
-  aria-label?: string
-  aria-labelledby?: string
-  bottom?: Responsive<DimensionValue>
-  children: [ReactElement, ReactElement]
-  contextualHelp?: ReactNode
-  end?: Responsive<DimensionValue>
-  flex?: Responsive<string | number | boolean>
-  flexBasis?: Responsive<number | string>
-  flexGrow?: Responsive<number>
-  flexShrink?: Responsive<number>
-  gridArea?: Responsive<string>
-  gridColumn?: Responsive<string>
-  gridColumnEnd?: Responsive<string>
-  gridColumnStart?: Responsive<string>
-  gridRow?: Responsive<string>
-  gridRowEnd?: Responsive<string>
-  gridRowStart?: Responsive<string>
-  height?: Responsive<DimensionValue>
-  id?: string
-  isDisabled?: boolean
-  isHidden?: Responsive<boolean>
-  isRequired?: boolean
-  justifySelf?: Responsive<'auto' | 'normal' | 'start' | 'end' | 'flex-start' | 'flex-end' | 'self-start' | 'self-end' | 'center' | 'left' | 'right' | 'stretch'>
-  label?: ReactNode
-  labelAlign?: Alignment = 'start'
-  labelPosition?: LabelPosition = 'top'
-  left?: Responsive<DimensionValue>
-  margin?: Responsive<DimensionValue>
-  marginBottom?: Responsive<DimensionValue>
-  marginEnd?: Responsive<DimensionValue>
-  marginStart?: Responsive<DimensionValue>
-  marginTop?: Responsive<DimensionValue>
-  marginX?: Responsive<DimensionValue>
-  marginY?: Responsive<DimensionValue>
-  maxHeight?: Responsive<DimensionValue>
-  maxWidth?: Responsive<DimensionValue>
-  minHeight?: Responsive<DimensionValue>
-  minWidth?: Responsive<DimensionValue>
-  necessityIndicator?: NecessityIndicator = 'icon'
-  order?: Responsive<number>
-  position?: Responsive<'static' | 'relative' | 'absolute' | 'fixed' | 'sticky'>
-  right?: Responsive<DimensionValue>
-  start?: Responsive<DimensionValue>
-  top?: Responsive<DimensionValue>
-  width?: Responsive<DimensionValue>
-  zIndex?: Responsive<number>
-}

/tmp/dist/base-api/@react-spectrum/searchwithin:SpectrumSearchWithinProps

-SpectrumSearchWithinProps {
-  UNSAFE_className?: string
-  UNSAFE_style?: CSSProperties
-  alignSelf?: Responsive<'auto' | 'normal' | 'start' | 'end' | 'center' | 'flex-start' | 'flex-end' | 'self-start' | 'self-end' | 'stretch'>
-  aria-describedby?: string
-  aria-details?: string
-  aria-label?: string
-  aria-labelledby?: string
-  bottom?: Responsive<DimensionValue>
-  children: [ReactElement, ReactElement]
-  contextualHelp?: ReactNode
-  end?: Responsive<DimensionValue>
-  flex?: Responsive<string | number | boolean>
-  flexBasis?: Responsive<number | string>
-  flexGrow?: Responsive<number>
-  flexShrink?: Responsive<number>
-  gridArea?: Responsive<string>
-  gridColumn?: Responsive<string>
-  gridColumnEnd?: Responsive<string>
-  gridColumnStart?: Responsive<string>
-  gridRow?: Responsive<string>
-  gridRowEnd?: Responsive<string>
-  gridRowStart?: Responsive<string>
-  height?: Responsive<DimensionValue>
-  id?: string
-  isDisabled?: boolean
-  isHidden?: Responsive<boolean>
-  isRequired?: boolean
-  justifySelf?: Responsive<'auto' | 'normal' | 'start' | 'end' | 'flex-start' | 'flex-end' | 'self-start' | 'self-end' | 'center' | 'left' | 'right' | 'stretch'>
-  label?: ReactNode
-  labelAlign?: Alignment = 'start'
-  labelPosition?: LabelPosition = 'top'
-  left?: Responsive<DimensionValue>
-  margin?: Responsive<DimensionValue>
-  marginBottom?: Responsive<DimensionValue>
-  marginEnd?: Responsive<DimensionValue>
-  marginStart?: Responsive<DimensionValue>
-  marginTop?: Responsive<DimensionValue>
-  marginX?: Responsive<DimensionValue>
-  marginY?: Responsive<DimensionValue>
-  maxHeight?: Responsive<DimensionValue>
-  maxWidth?: Responsive<DimensionValue>
-  minHeight?: Responsive<DimensionValue>
-  minWidth?: Responsive<DimensionValue>
-  necessityIndicator?: NecessityIndicator = 'icon'
-  order?: Responsive<number>
-  position?: Responsive<'static' | 'relative' | 'absolute' | 'fixed' | 'sticky'>
-  right?: Responsive<DimensionValue>
-  start?: Responsive<DimensionValue>
-  top?: Responsive<DimensionValue>
-  width?: Responsive<DimensionValue>
-  zIndex?: Responsive<number>
-}

@snowystinger snowystinger added this pull request to the merge queue Jun 4, 2025
Merged via the queue into main with commit 066cabf Jun 4, 2025
30 checks passed
@snowystinger snowystinger deleted the remove-searchwithin branch June 4, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants