Skip to content

feat(s2): coachmarks #7590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Apr 22, 2025
Merged

feat(s2): coachmarks #7590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
e4522ee
GW coachmark
jluyau Dec 19, 2024
d42a8ee
fix TS errors
jluyau Jan 9, 2025
fb42457
Merge branch 'main' of github.com:adobe/react-spectrum into coachmarks
jluyau Jan 9, 2025
3b7f7bf
remove unrelated files, update yarn.lock
jluyau Jan 9, 2025
a104309
remove unneeded import
jluyau Jan 9, 2025
1162a44
lint fix
jluyau Jan 9, 2025
8cbcadf
more lint fixes
jluyau Jan 9, 2025
a33a533
remove old stories
jluyau Jan 9, 2025
6c01220
remove unused import
jluyau Jan 9, 2025
0512bee
Merge branch 'main' into coachmarks
snowystinger Jan 15, 2025
e0eca9e
Merge branch 'main' into coachmarks
snowystinger Mar 10, 2025
3601365
fix yarn lock
snowystinger Mar 11, 2025
5c252ef
Merge branch 'main' into coachmarks
snowystinger Mar 20, 2025
7fb0ea7
API changes to bring in line with other s2 components
snowystinger Mar 20, 2025
be9343b
Cleanup to get merged
snowystinger Apr 10, 2025
7f0f308
fix lint and tests
snowystinger Apr 10, 2025
109d95f
Merge branch 'main' into coachmarks
snowystinger Apr 10, 2025
68ac81a
Merge branch 'main' into coachmarks
snowystinger Apr 11, 2025
b7f9e10
Merge branch 'main' into coachmarks
snowystinger Apr 15, 2025
f6911aa
remove from exports entirely
snowystinger Apr 18, 2025
0041a72
Merge branch 'main' into coachmarks
snowystinger Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/@react-spectrum/s2/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,11 @@
"@react-aria/i18n": "^3.12.8",
"@react-aria/interactions": "^3.25.0",
"@react-aria/live-announcer": "^3.4.2",
"@react-aria/overlays": "^3.27.0",
"@react-aria/utils": "^3.28.2",
"@react-spectrum/utils": "^3.12.4",
"@react-stately/layout": "^4.2.2",
"@react-stately/menu": "^3.9.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these dependencies aren't used anywhere?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/adobe/react-spectrum/pull/7590/files#diff-8cd68236c9fcef8c0976a16402d56ed41af3bbdac40c17b02ff088920c1d51deR52

wanted to revisit this in followup because I'm not sure we should allow menus in a coachmark

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, wrong one, @react-aria/overlays is unused.

"@react-stately/utils": "^3.10.6",
"@react-types/dialog": "^3.5.17",
"@react-types/grid": "^3.3.1",
Expand Down
Loading