feat: add Seeed XIAO nRF52840 BLE/Sense boards with SoftDevice S340 #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes
UF2_BOARD_IDin your board.h follow correct format from uf2 specsDescription of Change
This PR needs #359 as a prerequisite and extends the two existing Seeed XIAO nRF52840 BLE and Sense boards with SoftDevice S340 functionality. The automatic build workflow for these two new boards will fail until #359 has been pulled as the closed source files are not included and S340 builds are then excluded. The build only works locally after following the instructions in the README.md to add the necessary closed source files. It doesn't break anything else.