-
Notifications
You must be signed in to change notification settings - Fork 61
Raha M.Rastagar, Jamie Horvath Sharks C17 Digital #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,20 @@ | ||
| from flask import Flask | ||
| from flask_sqlalchemy import SQLAlchemy | ||
| from flask_migrate import Migrate | ||
|
|
||
| db = SQLAlchemy() | ||
| migrate = Migrate() | ||
|
|
||
| def create_app(test_config=None): | ||
| app = Flask(__name__) | ||
|
|
||
| app.comfig['SQLALCHEMY_TRACK_MODIFICATIONS'] = False | ||
| app.config['SQLALCHEMY_DATABASE_URI'] = 'postgresql+psycopg2://postgres:postgres@localhost:5432/solar_system_development' | ||
|
|
||
| db.init_app(app) | ||
| migrate.init_app(app, db) | ||
|
|
||
| from .routes import planet_bp | ||
| app.register_blueprint(planet_bp) | ||
|
|
||
| return app | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| def create_app(test_config=None): | ||
|
|
||
| from app.models.book import Book | ||
|
|
||
| return app |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| from app import db | ||
|
|
||
| class Plant(db.Model): | ||
| id = db.Column(db.Integer, primary_key=True, autoincrement=True) | ||
| name = db.Column(db.String) | ||
| description = db.Column(db.String) | ||
| moons = db.Column(db.Integer) | ||
|
|
||
| def to_json(self): | ||
| return { | ||
| "id": self.id, | ||
| "name": self.name, | ||
| "desciption": self.description, | ||
| "moons": self.moons | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,53 @@ | ||
| from flask import Blueprint | ||
| from flask import Blueprint, jsonify, abort, make_response | ||
|
|
||
|
|
||
| class Planet: | ||
| def __init__(self, id, name, description, moons): | ||
| self.id = id | ||
| self.name = name | ||
| self.description = description | ||
| self.moons = moons | ||
| def to_json(self): | ||
| return { | ||
| "id": self.id, | ||
| "name": self.name, | ||
| "desciption": self.description, | ||
| "moons": self.moons | ||
| } | ||
|
Comment on lines
+4
to
+16
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice work! This There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't forget to add a space in between our functions to improve readability. |
||
|
|
||
| planets = [ | ||
| Planet(1, "Mercury", "the nearest planet to the Sun", 0), | ||
| Planet(2, "Venus", "named after the Roman goddess of love and beauty", 0), | ||
| Planet(3, "Earth", "Home. the only astronomical object known to harbor life", 1), | ||
| Planet(4, "Mars", "is often called the Red Planet", 2), | ||
| Planet(5, "Jupiter", "more then 2.5 time the mass of all other planets", 79), | ||
| Planet(6, "Saturn", "second-largest planet in the Solar System", 82), | ||
| Planet(7, "Uranus", "named after the Greek god of the sky", 27), | ||
| Planet(8, "Neptune", "the densest giant planet", 14), | ||
| Planet(9, "Pluto", "may or may not be a planet, poor Pluto", 1) | ||
| ] | ||
|
Comment on lines
+27
to
+28
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I disagree... Pluto is most definitely a planet! 😆 |
||
| planet_bp = Blueprint("planets", __name__, url_prefix="/planets") | ||
|
|
||
| @planet_bp.route("", methods=["GET"]) | ||
| def read_planets(): | ||
| planets_response = [] | ||
| for planet in planets: | ||
| planets_response.append(planet.to_json()) | ||
| return jsonify(planets_response), 200 | ||
|
Comment on lines
+32
to
+36
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Great work! We can also use a list comprehension to write the logic for this function: def read_planets():
planets_response = [planet.to_json() for planet in planets]
return jsonify(planets_response), 200 |
||
|
|
||
| def validate_planet(planet_id): | ||
| try: | ||
| planet_id = int(planet_id) | ||
| except: | ||
| abort(make_response({"message":f"planet {planet_id} invalid"}, 400)) | ||
|
|
||
| for planet in planets: | ||
| if planet.id == planet_id: | ||
| return planet | ||
|
|
||
| abort(make_response({"message":f"planet {planet_id} not found"}, 404)) | ||
|
Comment on lines
+38
to
+48
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 Nice work! The validation for detecting a bad id and for an id with no record looks good! |
||
|
|
||
| @planet_bp.route("/<planet_id>", methods=["GET"]) | ||
| def read_one_planet(planet_id): | ||
| planet = validate_planet(planet_id) | ||
| return jsonify(planet.to_json(), 200) | ||
|
Comment on lines
+50
to
+53
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice use of the helper method! This looks great! |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍