Ocelots - Dalia Ali #8
Conversation
kelsey-steven-ada
left a comment
kelsey-steven-ada
left a comment
There was a problem hiding this comment.
Looks good! I’ve added some suggestions, let me know if there's anything I can clarify ^_^
| "Y", | ||
| "Z", | ||
| ]; | ||
| const lettersPoolDeepcopy = JSON.parse(JSON.stringify(lettersPool)); |
There was a problem hiding this comment.
Performing a copy like this is a great place to use the spread operator! What could that look like?
Since lettersPool is declared inside the function, the data structure gets re-created every time we call the function. This means we shouldn't need to copy lettersPool to ensure that changes aren't persisted across calls.
| const hand = []; | ||
|
|
||
| for (let i = 0; i < 10; i++) { | ||
| const random_number = Math.floor( | ||
| Math.random() * lettersPoolDeepcopy.length | ||
| ); | ||
| hand.push(lettersPoolDeepcopy[random_number]); | ||
| lettersPoolDeepcopy.splice(random_number, 1); | ||
| } | ||
| return hand; |
| for (const letter of input) { | ||
| if (lettersInHand.includes(letter)) { | ||
| const index = lettersInHand.indexOf(letter); | ||
| lettersInHand.splice(index, 1); | ||
| } else { | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
Nice approach! If we needed to reduce the time complexity of our solution, another approach could be to build a frequency map of our hand then loop over the characters in the input, checking if the character is in our frequency map, and if it is, then check the value to see if there are still tiles left in our hand for that letter.
| const index = lettersInHand.indexOf(letter); | ||
| lettersInHand.splice(index, 1); | ||
| } else { | ||
| return false; |
|
|
||
| export const scoreWord = (word) => { | ||
| // Implement this method for wave 3 | ||
| const lettersValue = { |
There was a problem hiding this comment.
I like keeping these in the function that uses them so they're close to where they are referenced.
| }; | ||
| let score = 0; | ||
| word = word.toUpperCase(); | ||
| for (const letter of word) { |
There was a problem hiding this comment.
Nice use of a for...of loop.
| for (const letter of word) { | ||
| score += lettersValue[letter]; | ||
| } |
There was a problem hiding this comment.
This could have an unexpected result if the string word has characters that aren't in lettersValue. If we have an input like "ABC DEF" then score will hold NaN (Not a Number) after the loop. If we wanted to skip non-alphabetic characters or characters that aren't in lettersValue, how could we do that?
2 participants
No description provided.