Ocelots - Jennifer Dai #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilana-adadev
reviewed
Feb 1, 2023
src/adagrams.js
Outdated
| // Implement this method for wave 1 | ||
| // find the random letters | ||
| let letters = []; | ||
| for(let i = 0; letters.length < 10; ++i){ |
There was a problem hiding this comment.
I wonder if it's possible that this is causing the long, or infinite loop, that's coming up in testing for me. Is there some chance that letters could never reach length 10?
…w letter function.
ilana-adadev
reviewed
Feb 2, 2023
|
|
||
| export const drawLetters = () => { | ||
| // Implement this method for wave 1 | ||
| const LETTER_POOL = { |
There was a problem hiding this comment.
Great debugging. How interesting that it was likely a variable scope issue!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.