-
Notifications
You must be signed in to change notification settings - Fork 218
feat: Wire particle hypothesis from truth estimated seeding to parameter estimation #4713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andiwand
wants to merge
9
commits into
acts-project:main
Choose a base branch
from
andiwand:ex-truthestseeding-wire-particlehypot
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Wire particle hypothesis from truth estimated seeding to parameter estimation #4713
andiwand
wants to merge
9
commits into
acts-project:main
from
andiwand:ex-truthestseeding-wire-particlehypot
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulgessinger
previously approved these changes
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, couple of minor comments.
...Algorithms/TrackFinding/include/ActsExamples/TrackFinding/TrackParamsEstimationAlgorithm.hpp
Outdated
Show resolved
Hide resolved
Examples/Algorithms/TrackFinding/src/TrackParamsEstimationAlgorithm.cpp
Outdated
Show resolved
Hide resolved
Examples/Algorithms/TrackFinding/src/TrackParamsEstimationAlgorithm.cpp
Outdated
Show resolved
Hide resolved
Examples/Algorithms/TruthTracking/ActsExamples/TruthTracking/TruthSeedingAlgorithm.cpp
Outdated
Show resolved
Hide resolved
…rithm.cpp Co-authored-by: Paul Gessinger <[email protected]>
…ruthSeedingAlgorithm.cpp Co-authored-by: Paul Gessinger <[email protected]>
paulgessinger
approved these changes
Oct 16, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only the truth smeared seeding can provide a truth particle hypothesis while the truth estimated seeding will use the one specified in the parameter estimation. This PR pipes another entry on the whiteboard through to supply particle hypotheses to the parameter estimation which is now supplied in the truth estimated seeding case.
--- END COMMIT MESSAGE ---