feat: Hashing seeding for Seeding2
#4681
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Examples
| std::vector<std::vector<SpacePointIndex2>> result; | ||
| result.reserve(resultSets.size()); | ||
| for (const auto& spSet : resultSets) { | ||
| result.emplace_back(spSet.begin(), spSet.end()); |
There was a problem hiding this comment.
A filter on empty spSet might be missing here, leading to as much returned bucket as the number of bins (while empty buckets are not needed) which might be more than the number of space points.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports the hashing seeding plugin and prototype Examples algorithm to the new space point and seeding API.
--- END COMMIT MESSAGE ---